All of lore.kernel.org
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] sdl: overwrite libpth autodetection
Date: Thu, 19 Nov 2015 23:33:46 +0200	[thread overview]
Message-ID: <20151119213346.GT2203@tarshish> (raw)
In-Reply-To: <1447968633-10830-1-git-send-email-ps.report@gmx.net>

Hi Peter,

On Thu, Nov 19, 2015 at 10:30:33PM +0100, Peter Seiderer wrote:
> The sdl libpth autodetection gets confused in case a host
> version is present. Overwrite libpth autodection for the
> target build dependent on BR2_PACKAGE_LIBPTHSEM and
> BR2_PACKAGE_LIBPTHSEM_COMPAT and use pth-config from
> staging directory.
> 
> Fixes [1]:
> 
> checking for pthreads... no
> checking for pth-config... /usr/bin/pth-config
> checking pth... yes
> [...]
> ./src/SDL.c:33:17: fatal error: pth.h: No such file or directory
>  #include <pth.h>
> 
> [1] http://autobuild.buildroot.net/results/733/73330e51b3c099d179004db0b9522ac13358b8f7
> 
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
> Changes v1 -> v2:
>   - add SDL_DEPENDENCIES += libpthsem (suggested by Baruch Siach)
>   - fix libpth enable logic, needs BR2_PACKAGE_LIBPTHSEM and BR2_PACKAGE_LIBPTHSEM_COMPAT
>   - overwrite ac_cv_path_PTH_CONFIG to use the right pth-config from
>     staging dir
> ---
>  package/sdl/sdl.mk | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/package/sdl/sdl.mk b/package/sdl/sdl.mk
> index 78eb4dd..e976905 100644
> --- a/package/sdl/sdl.mk
> +++ b/package/sdl/sdl.mk
> @@ -58,6 +58,15 @@ ifneq ($(BR2_USE_MMU),y)
>  SDL_CONF_OPTS += --enable-dga=no
>  endif
>  
> +# overwrite autodection (prevents confusion with host libpth version)
> +ifeq ($(BR2_PACKAGE_LIBPTHSEM)$(BR2_PACKAGE_LIBPTHSEM_COMPAT),yy)

Testing for BR2_PACKAGE_LIBPTHSEM_COMPAT alone should be enough since 
BR2_PACKAGE_LIBPTHSEM_COMPAT depends on BR2_PACKAGE_LIBPTHSEM.

> +SDL_CONF_OPTS += --enable-pth
> +SDL_CONF_ENV += ac_cv_path_PTH_CONFIG=$(STAGING_DIR)/usr/bin/pth-config
> +SDL_DEPENDENCIES += libpthsem
> +else
> +SDL_CONF_OPTS += --disable-pth
> +endif
> +
>  ifeq ($(BR2_PACKAGE_TSLIB),y)
>  SDL_DEPENDENCIES += tslib
>  endif

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2015-11-19 21:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 21:30 [Buildroot] [PATCH v2] sdl: overwrite libpth autodetection Peter Seiderer
2015-11-19 21:33 ` Baruch Siach [this message]
2015-11-19 21:42   ` Peter Seiderer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151119213346.GT2203@tarshish \
    --to=baruch@tkos.co.il \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.