From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Keeping Subject: Re: [PATCH] ARM: dts: rockchip: set system-power-controller on rk3288-rock2 Date: Thu, 19 Nov 2015 22:05:04 +0000 Message-ID: <20151119220503.GA30067@river.lan> References: <1447940731-5672-1-git-send-email-john@metanate.com> <1807407.tUv2FxFrog@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1807407.tUv2FxFrog@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Heiko Stuebner Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Sjoerd Simons List-Id: linux-rockchip.vger.kernel.org On Thu, Nov 19, 2015 at 10:19:32PM +0100, Heiko Stuebner wrote: > Am Donnerstag, 19. November 2015, 13:45:31 schrieb John Keeping: > > Signed-off-by: John Keeping > > please always provide at least a short patch description too. > I've applied the patch but reworded it to > > ARM: dts: rockchip: set system-power-controller property on rk3288-rock2 > > The act8846 on rock2 boards controls the system power, so add the > appropriate property to allow turning off the board. > > Please holler if you disagree and want it described differently :-) . No objections here, that sounds great. Thanks, John > > --- > > arch/arm/boot/dts/rk3288-rock2-som.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm/boot/dts/rk3288-rock2-som.dtsi b/arch/arm/boot/dts/rk3288-rock2-som.dtsi > > index 1813b7c3..1ece66f 100644 > > --- a/arch/arm/boot/dts/rk3288-rock2-som.dtsi > > +++ b/arch/arm/boot/dts/rk3288-rock2-som.dtsi > > @@ -109,6 +109,7 @@ > > act8846: act8846@5a { > > compatible = "active-semi,act8846"; > > reg = <0x5a>; > > + system-power-controller; > > inl1-supply = <&vcc_io>; > > inl2-supply = <&vcc_sys>; > > inl3-supply = <&vcc_20>; > > >