From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzlRf-0001Nf-88 for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:09:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZzlRc-000514-1h for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:09:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZzlRb-00050v-Ry for qemu-devel@nongnu.org; Fri, 20 Nov 2015 08:09:39 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 01B8AC0BFBA7 for ; Fri, 20 Nov 2015 13:09:37 +0000 (UTC) Date: Fri, 20 Nov 2015 13:09:33 +0000 From: "Dr. David Alan Gilbert" Message-ID: <20151120130933.GD12796@work-vm> References: <1448021712-40190-1-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448021712-40190-1-git-send-email-pbonzini@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.5] iothread: include id in thread name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, stefanha@redhat.com * Paolo Bonzini (pbonzini@redhat.com) wrote: > This makes it easier to find the desired thread > > Signed-off-by: Paolo Bonzini > --- > iothread.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/iothread.c b/iothread.c > index da6ce7b..8a1d6f8 100644 > --- a/iothread.c > +++ b/iothread.c > @@ -72,6 +72,7 @@ static void iothread_complete(UserCreatable *obj, Error **errp) > { > Error *local_error = NULL; > IOThread *iothread = IOTHREAD(obj); > + char *name, *thread_name; > > iothread->stopping = false; > iothread->thread_id = -1; > @@ -87,8 +88,12 @@ static void iothread_complete(UserCreatable *obj, Error **errp) > /* This assumes we are called from a thread with useful CPU affinity for us > * to inherit. > */ > - qemu_thread_create(&iothread->thread, "iothread", iothread_run, > + name = object_get_canonical_path_component(OBJECT(obj)); > + thread_name = g_strdup_printf("iothread %s", name); Yes, that's a good idea; Can you shorten that to just "IO %s" please, for three reasons: 1) There is a ~14 character limit on the size of that string 2) We use CPU ... for the CPU threads. 3) It's a threadname, it doesn't need to say thread Dave > + qemu_thread_create(&iothread->thread, thread_name, iothread_run, > iothread, QEMU_THREAD_JOINABLE); > + g_free(thread_name); > + g_free(name); > > /* Wait for initialization to complete */ > qemu_mutex_lock(&iothread->init_done_lock); > -- > 1.8.3.1 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK