All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Tom Herbert <tom@herbertland.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Kernel Team <kernel-team@fb.com>,
	davewatson@fb.com,
	Alexei Starovoitov <alexei.starovoitov@gmail.com>
Subject: Re: [PATCH net-next 4/6] kcm: Kernel Connection Multiplexor module
Date: Fri, 20 Nov 2015 18:27:10 -0500	[thread overview]
Message-ID: <20151120232710.GC10508@oracle.com> (raw)
In-Reply-To: <CALx6S36p3RAy+7ZO6G=MjAyLz95zr-UD7AUaFe8kS8EVUHHFNw@mail.gmail.com>

On (11/20/15 15:19), Tom Herbert wrote:
> 
> I did notice that RDS is just creating sglist, but I also noticed that
> this requires allocating "struct rds_message" which holds pointers to
> the sglist, list pointers for a queue, etc. This looks to me like its
> emulating skbuffs anyway. I haven't looked if there's performance

yes, some of that might come from the IB origins of the code
so that it could be shared with an IB transport. I was just wondering
if directly using sk_buffs would be a significant perf win for rds-tcp.

> issues otherwise in using the fraglist. It might be interesting if
> there was an interface to send skbufs on a kernel socket.

yes. Or if there was a way to  factor out the non-zero page-order
enhancements in skb_page_frag_refill in a way that they could be
shared with RDS.

--Sowmini

  reply	other threads:[~2015-11-20 23:27 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 21:21 [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM) Tom Herbert
2015-11-20 21:21 ` [PATCH net-next 1/6] rcu: Add list_next_or_null_rcu Tom Herbert
2015-11-20 21:21 ` [PATCH net-next 2/6] net: Make sock_alloc exportable Tom Herbert
2015-11-20 21:21 ` [PATCH net-next 3/6] net: Add MSG_BATCH flag Tom Herbert
2015-11-23 10:02   ` Hannes Frederic Sowa
2015-11-20 21:21 ` [PATCH net-next 4/6] kcm: Kernel Connection Multiplexor module Tom Herbert
2015-11-20 22:50   ` Sowmini Varadhan
2015-11-20 23:19     ` Tom Herbert
2015-11-20 23:27       ` Sowmini Varadhan [this message]
2015-11-20 23:10   ` Alexei Starovoitov
2015-11-20 23:20     ` Tom Herbert
2015-11-23  9:42   ` Daniel Borkmann
2015-11-20 21:21 ` [PATCH net-next 5/6] kcm: Add statistics and proc interfaces Tom Herbert
2015-11-20 21:22 ` [PATCH net-next 6/6] kcm: Add description in Documentation Tom Herbert
2015-11-23  9:53 ` [PATCH net-next 0/6] kcm: Kernel Connection Multiplexor (KCM) Hannes Frederic Sowa
2015-11-23 12:43   ` Sowmini Varadhan
2015-11-23 17:33   ` Tom Herbert
2015-11-23 19:35     ` Hannes Frederic Sowa
2015-11-23 19:54     ` David Miller
2015-11-23 20:02       ` Tom Herbert
2015-11-24 11:25       ` Hannes Frederic Sowa
2015-11-24 15:49         ` David Miller
2015-11-24 15:27       ` Florian Westphal
2015-11-24 15:49         ` Eric Dumazet
2015-11-24 18:09           ` Rick Jones
2015-11-24 15:55         ` David Miller
2015-11-24 16:25           ` Florian Westphal
2015-11-24 17:00             ` Tom Herbert
2015-11-24 17:16               ` Florian Westphal
2015-11-24 17:43                 ` Tom Herbert
2015-11-24 20:55                   ` Florian Westphal
2015-11-24 21:49                     ` Tom Herbert
2015-11-24 22:22                       ` Florian Westphal
2015-11-24 22:25                         ` David Miller
2015-11-24 22:45                           ` Florian Westphal
2015-11-24 23:13                           ` Hannes Frederic Sowa
2015-11-24 18:23             ` Hannes Frederic Sowa
2015-11-24 18:59               ` Alexei Starovoitov
2015-11-24 19:16                 ` Hannes Frederic Sowa
2015-11-24 19:26                   ` Hannes Frederic Sowa
2015-11-24 20:23                   ` Alexei Starovoitov
     [not found]                     ` <1448402288.1489559.449199721.64EBB346@webmail.messagingengine.com>
     [not found]                       ` <20151124222109.GA86838@ast-mbp.thefacebook.com>
2015-11-25 10:38                         ` Hannes Frederic Sowa
2015-11-25 16:26             ` Sowmini Varadhan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151120232710.GC10508@oracle.com \
    --to=sowmini.varadhan@oracle.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=davem@davemloft.net \
    --cc=davewatson@fb.com \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.