From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Andy Lutomirski <luto@kernel.org>,
platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake
Date: Sat, 21 Nov 2015 01:11:55 +0100 [thread overview]
Message-ID: <201511210111.55932@pali> (raw)
In-Reply-To: <20151121000636.GG7413@malice.jf.intel.com>
[-- Attachment #1: Type: Text/Plain, Size: 620 bytes --]
On Saturday 21 November 2015 01:06:36 Darren Hart wrote:
> > - keymap = kcalloc(hotkey_num + 1, sizeof(struct key_entry),
> > GFP_KERNEL); + keymap = kcalloc(hotkey_num +
> > ARRAY_SIZE(dell_wmi_extra_keymap),
>
> This previously allocated kotkey_num + 1, but you dropeed the +1,
> making it eactly the size of hotkey_num + the new entries you added.
>
> Why don't we need the +1 anymore? (it isn't clear to me why we needed
> to before actually, but I want to confirm you considered it).
>
Last entry in keymap array must be KE_END, right? So this is that +1.
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2015-11-21 0:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 5:49 [PATCH 0/3] dell_wmi: XPS 13 Skylake support and misc stuff Andy Lutomirski
2015-11-14 5:49 ` [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake Andy Lutomirski
2015-11-14 9:27 ` Pali Rohár
2015-11-14 15:48 ` Andy Lutomirski
2015-11-14 16:13 ` Pali Rohár
[not found] ` <CALCETrWss=zCWhNkR2S_oi_m3W1xNO+UL_-uOnOVeLh5WHsDgQ@mail.gmail.com>
2015-11-17 8:36 ` Pali Rohár
2015-11-17 19:03 ` Andy Lutomirski
2015-11-18 3:44 ` Andy Lutomirski
2015-11-18 21:24 ` Andy Lutomirski
2015-11-19 8:19 ` Pali Rohár
2015-11-21 0:06 ` Darren Hart
2015-11-21 0:11 ` Pali Rohár [this message]
2015-11-21 0:12 ` Andy Lutomirski
2015-11-22 2:04 ` D. Jared Dominguez
2015-11-23 14:53 ` Pali Rohár
2016-01-21 10:17 ` Pali Rohár
2016-01-22 0:08 ` Mario Limonciello
2016-01-22 0:13 ` Andy Lutomirski
2016-01-22 8:26 ` Pali Rohár
2016-01-22 15:58 ` Mario Limonciello
2016-01-22 17:11 ` Pali Rohár
2015-11-14 5:49 ` [PATCH 2/3] dell_wmi: Use a C99-style array for bios_to_linux_keycode Andy Lutomirski
2015-11-14 9:30 ` Pali Rohár
2015-11-21 0:09 ` Darren Hart
2015-11-21 0:20 ` Pali Rohár
2015-11-21 0:26 ` Darren Hart
2015-11-21 0:28 ` Andy Lutomirski
2015-11-14 5:49 ` [PATCH 3/3] dell_wmi: Improve unknown hotkey handling Andy Lutomirski
2015-11-14 9:33 ` Pali Rohár
2015-11-17 1:35 ` Andy Lutomirski
2015-11-21 0:29 ` Darren Hart
2015-11-21 0:34 ` Andy Lutomirski
2015-11-21 0:41 ` Pali Rohár
2015-11-21 0:44 ` Andy Lutomirski
2015-11-21 0:14 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511210111.55932@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.