Re: [PATCH 1/2] mac80211: add support to set_coalesce

[Olav Haugan <ohaugan@codeaurora.org>]

On 15-10-30 10:59:41, Johannes Berg wrote:
> 
> > +++ b/net/mac80211/driver-ops.h
> > @@ -1355,4 +1355,16 @@ static inline void drv_wake_tx_queue(struct 
> > ieee80211_local *local,
> >  	local->ops->wake_tx_queue(&local->hw, &txq->txq);
> >  }
> >  
> > +static inline int drv_set_coalesce(struct ieee80211_local *local,
> > +				   struct cfg80211_coalesce 
> > *coalesce)
> > +{
> > +	u32 ret = 0;
> > 
> This doesn't seem right - now you're accepting any call even if it's
> not really done by the driver?
> 

I assume you mean we need the following check:

if (!local->ops->set_coalesce)
	return -EOPNOTSUPP

-- 
.Olav

The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project