From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35663)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a0nAW-0008Ee-25
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 04:12:16 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1a0nAU-0003cc-Ow
	for qemu-devel@nongnu.org; Mon, 23 Nov 2015 04:12:15 -0500
Date: Mon, 23 Nov 2015 17:12:04 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20151123091204.GA689@ad.usersys.redhat.com>
References: <1448245930-15031-1-git-send-email-famz@redhat.com>
	<87twodcgqz.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87twodcgqz.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting
 QEMU in 119 and 120
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, qemu-block@nongnu.org, mreitz@redhat.com

On Mon, 11/23 08:33, Markus Armbruster wrote:
> Fam Zheng <famz@redhat.com> writes:
> 
> > Otherwise, a window flashes on my desktop (built with SDL). Add this as
> > other cases have it.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> >
> > ---
> > v2: Fix 119 too. [Max]
> > ---
> >  tests/qemu-iotests/119 | 2 +-
> >  tests/qemu-iotests/120 | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tests/qemu-iotests/119 b/tests/qemu-iotests/119
> > index 9a11f1b..cc6ec07 100755
> > --- a/tests/qemu-iotests/119
> > +++ b/tests/qemu-iotests/119
> > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
> >        {'execute': 'human-monitor-command',
> >         'arguments': {'command-line': 'qemu-io drv \"read -P 0 0 64k\"'}}
> >        {'execute': 'quit'}" \
> > -    | $QEMU -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
> > +    | $QEMU -nographic -drive id=drv,if=none,file="$TEST_IMG",driver=nbd \
> >              -qmp stdio -nodefaults \
> >      | _filter_qmp | _filter_qemu_io
> >  
> > diff --git a/tests/qemu-iotests/120 b/tests/qemu-iotests/120
> > index 9f13078..d899a3f 100755
> > --- a/tests/qemu-iotests/120
> > +++ b/tests/qemu-iotests/120
> > @@ -49,7 +49,7 @@ echo "{'execute': 'qmp_capabilities'}
> >        {'execute': 'human-monitor-command',
> >         'arguments': {'command-line': 'qemu-io drv \"write -P 42 0 64k\"'}}
> >        {'execute': 'quit'}" \
> > -    | $QEMU -qmp stdio -nodefaults \
> > +    | $QEMU -qmp stdio -nographic -nodefaults \
> >              -drive id=drv,if=none,file="$TEST_IMG",driver=raw,file.driver=$IMGFMT \
> >      | _filter_qmp | _filter_qemu_io
> >  $QEMU_IO -c 'read -P 42 0 64k' "$TEST_IMG" | _filter_qemu_io
> 
> -nographic is legacy.  Using legacy options is fine, but I wonder
> whether you want -display none here.  Unless you really want to redirect
> serial and parallel port, I suspect you do.

I was just following other cases, I'm fine with either way but I suspect it's
worth to convert them. So if there is no other problem let's be consistent and
stick to -nographic for now. Thanks for pointing out, though.

Fam