All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: socfpga: Repair SoCrates board
Date: Mon, 23 Nov 2015 09:32:55 +0100	[thread overview]
Message-ID: <201511230932.56052.marex@denx.de> (raw)
In-Reply-To: <5652B944.7060103@denx.de>

On Monday, November 23, 2015 at 07:59:16 AM, Stefan Roese wrote:
> Hi Marek,

Hi!

> On 21.11.2015 13:40, Marek Vasut wrote:
> >>> +/*
> >>> + * PHY configuration
> >>> + */
> >>> +#ifdef CONFIG_PHY_MICREL_KSZ9021
> >>> +int board_phy_config(struct phy_device *phydev)
> >>> +{
> >>> +	int ret;
> >>> +	/*
> >>> +	 * These skew settings for the KSZ9021 ethernet phy is required for
> >>> ethernet +	 * to work reliably on most flavors of cyclone5 boards.
> >>> +	 */
> >>> +	ret = ksz9021_phy_extended_write(phydev,
> >>> +					 MII_KSZ9021_EXT_RGMII_RX_DATA_SKEW,
> >>> +					 0x0);
> >>> +	if (ret)
> >>> +		return ret;
> >>> +
> >>> +	ret = ksz9021_phy_extended_write(phydev,
> >>> +					 MII_KSZ9021_EXT_RGMII_TX_DATA_SKEW,
> >>> +					 0x0);
> >>> +	if (ret)
> >>> +		return ret;
> >>> +
> >>> +	ret = ksz9021_phy_extended_write(phydev,
> >>> +					 MII_KSZ9021_EXT_RGMII_CLOCK_SKEW,
> >>> +					 0xf0f0);
> >>> +	if (ret)
> >>> +		return ret;
> >>> +
> >>> +	if (phydev->drv->config)
> >>> +		return phydev->drv->config(phydev);
> >>> +
> >>> +	return 0;
> >>> +}
> >>> +#endif
> > 
> > Hi!
> > 
> >> v2 of the SoCrates comes with a different PHY, IIRC. So we might
> >> want to add some checking on the PHY model here at some time.
> > 
> > I don't have a socratesV2 and U-Boot does not support it either. Please
> > either mail me a socratesV2 or send a subsequent patch to add support
> > for socratesV2, I am open to either method.
> 
> I'll send a follow-up patch for this.

Thanks!

Best regards,
Marek Vasut

  reply	other threads:[~2015-11-23  8:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-20 16:17 [U-Boot] [PATCH] arm: socfpga: Repair SoCrates board Marek Vasut
2015-11-20 16:18 ` Marek Vasut
2015-11-21 12:22 ` Stefan Roese
2015-11-21 12:40   ` Marek Vasut
2015-11-23  6:59     ` Stefan Roese
2015-11-23  8:32       ` Marek Vasut [this message]
2015-11-23 13:45 ` [U-Boot] " Jan Viktorin
2015-11-23 14:23 ` Jan Viktorin
2015-11-23 14:23 ` Jan Viktorin
2015-11-23 16:05   ` Marek Vasut
     [not found] ` <20151123151248.25fc73a3@pcviktorin.fit.vutbr.cz>
2015-11-23 16:04   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201511230932.56052.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.