From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH 00/12] smaller iptunnel and ip6tunnel review
Date: Mon, 23 Nov 2015 15:28:57 -0800 [thread overview]
Message-ID: <20151123152857.3d733d97@xeon-e3> (raw)
In-Reply-To: <1447434545-32182-1-git-send-email-phil@nwl.cc>
On Fri, 13 Nov 2015 18:08:53 +0100
Phil Sutter <phil@nwl.cc> wrote:
> In an effort to try and merge iptunnel and ip6tunnel support code, I found a
> few things worth changing, mainly by comparing the two files.
>
> Please note that I did not test functionality of all supported tunnel modes,
> but since the changes are fairly small and obvious I hopefully didn't introduce
> too many bugs.
>
> Phil Sutter (12):
> ip{,6}tunnel: get rid of extraneous whitespace when printing
> ip/tunnel: introduce tnl_parse_key()
> ip{,6}tunnel: unify behaviour if physical device is not found
> iptunnel: use ll_name_to_index() for physical interface lookup
> ip{,6}tunnel: align do_tunnels_list() a bit
> ip6tunnel: print local/remote addresses like iptunnel does
> ip6tunnel: fix coding style: no newline between brace and else
> iptunnel: share common code when setting tunnel mode
> iptunnel: simplify parsing TTL, allow 'hlim' as identifier
> iptunnel: share common code when determining the default interface
> name
> iptunnel: sanitize copying tunnel name
> ip{,6}tunnel: put spaces around non-unary operators
>
> ip/ip6tunnel.c | 83 +++++++-------------
> ip/iptunnel.c | 239 ++++++++++++++++++++++-----------------------------------
> ip/tunnel.c | 15 ++++
> ip/tunnel.h | 1 +
> 4 files changed, 135 insertions(+), 203 deletions(-)
>
Sure these all make sense. Applied
prev parent reply other threads:[~2015-11-24 0:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 17:08 [iproute PATCH 00/12] smaller iptunnel and ip6tunnel review Phil Sutter
2015-11-13 17:08 ` [iproute PATCH 01/12] ip{,6}tunnel: get rid of extraneous whitespace when printing Phil Sutter
2015-11-13 17:08 ` [iproute PATCH 02/12] ip/tunnel: introduce tnl_parse_key() Phil Sutter
2015-11-13 17:08 ` [iproute PATCH 03/12] ip{,6}tunnel: unify behaviour if physical device is not found Phil Sutter
2015-11-13 17:08 ` [iproute PATCH 04/12] iptunnel: use ll_name_to_index() for physical interface lookup Phil Sutter
2015-11-13 17:08 ` [iproute PATCH 05/12] ip{,6}tunnel: align do_tunnels_list() a bit Phil Sutter
2015-11-13 17:30 ` David Laight
2015-11-13 17:53 ` Phil Sutter
2015-11-13 17:08 ` [iproute PATCH 06/12] ip6tunnel: print local/remote addresses like iptunnel does Phil Sutter
2015-11-13 17:09 ` [iproute PATCH 07/12] ip6tunnel: fix coding style: no newline between brace and else Phil Sutter
2015-11-13 17:09 ` [iproute PATCH 08/12] iptunnel: share common code when setting tunnel mode Phil Sutter
2015-11-13 17:09 ` [iproute PATCH 09/12] iptunnel: simplify parsing TTL, allow 'hlim' as identifier Phil Sutter
2015-11-13 17:09 ` [iproute PATCH 10/12] iptunnel: share common code when determining the default interface name Phil Sutter
2015-11-13 17:09 ` [iproute PATCH 11/12] iptunnel: sanitize copying tunnel name Phil Sutter
2015-11-13 17:09 ` [iproute PATCH 12/12] ip{,6}tunnel: put spaces around non-unary operators Phil Sutter
2015-11-23 23:28 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123152857.3d733d97@xeon-e3 \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.