From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH v2 1/6] ipaddress: make flush command more error-tolerant
Date: Mon, 23 Nov 2015 16:31:15 -0800 [thread overview]
Message-ID: <20151123163115.5f8be482@xeon-e3> (raw)
In-Reply-To: <1447014141-3565-2-git-send-email-phil@nwl.cc>
On Sun, 8 Nov 2015 21:22:16 +0100
Phil Sutter <phil@nwl.cc> wrote:
> The core issue here is that with promote_secondaries sysctl setting
> being turned off, removing the primary address implicitly removes all
> secondaries as well. Iproute is aware of this and therefore tries to
> remove all secondary addresses first to circumvent errors due to
> removing non-existent addresses. But this works only if not too many IP
> addresses are assigned to an interface, otherwise the RTM_GETADDR
> response is split up into multiple buffers. In my test-case, flushing
> more than 42 IPv4 addresses was sufficient to trigger an error:
>
> Failed to send flush request: Cannot assign requested address
>
> This patch fixes the issue by simply ignoring EADDRNOTAVAIL when
> flushing.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Patch does not apply to current tree. I applied an earlier patch from Neil Horman
and this supersedes this.
Please redo the patch series.
next prev parent reply other threads:[~2015-11-24 0:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 19:21 [iproute PATCH 0/6] flush many addresses and some cleanups Phil Sutter
2015-11-08 19:21 ` [iproute PATCH 1/6] ipaddress: make flush command more error-tolerant Phil Sutter
2015-11-08 19:21 ` [iproute PATCH 2/6] ipaddress: simplify ipaddr_flush() Phil Sutter
2015-11-08 19:21 ` [iproute PATCH 3/6] libnetlink: introduce nc_flags Phil Sutter
2015-11-08 19:21 ` [iproute PATCH 4/6] ipaddress: fix ipaddr_flush for Linux >= 3.1 Phil Sutter
2015-11-08 19:21 ` [iproute PATCH 5/6] ipaddress: drop unnecessary check in ipaddr_list_flush_or_save() Phil Sutter
2015-11-08 19:21 ` [iproute PATCH 6/6] iptoken: simplify iptoken_list a bit Phil Sutter
2015-11-08 20:22 ` [iproute PATCH v2 0/6] flush many addresses and some cleanups Phil Sutter
2015-11-08 20:22 ` [iproute PATCH v2 1/6] ipaddress: make flush command more error-tolerant Phil Sutter
2015-11-24 0:31 ` Stephen Hemminger [this message]
2015-11-24 14:30 ` [iproute PATCH v3 0/5] flush many addresses and some cleanups Phil Sutter
2015-11-24 14:31 ` [iproute PATCH v3 1/5] ipaddress: simplify ipaddr_flush() Phil Sutter
2015-11-24 14:31 ` [iproute PATCH v3 2/5] libnetlink: introduce nc_flags Phil Sutter
2015-11-24 14:31 ` [iproute PATCH v3 3/5] ipaddress: fix ipaddr_flush for Linux >= 3.1 Phil Sutter
2015-11-25 13:36 ` Sergei Shtylyov
2015-11-25 14:32 ` Phil Sutter
2015-11-25 14:40 ` Sergei Shtylyov
2015-11-24 14:31 ` [iproute PATCH v3 4/5] ipaddress: drop unnecessary check in ipaddr_list_flush_or_save() Phil Sutter
2015-11-24 14:31 ` [iproute PATCH v3 5/5] iptoken: simplify iptoken_list a bit Phil Sutter
2015-11-29 19:50 ` [iproute PATCH v3 0/5] flush many addresses and some cleanups Stephen Hemminger
2015-11-08 20:22 ` [iproute PATCH v2 2/6] ipaddress: simplify ipaddr_flush() Phil Sutter
2015-11-08 20:22 ` [iproute PATCH v2 3/6] libnetlink: introduce nc_flags Phil Sutter
2015-11-08 20:22 ` [iproute PATCH v2 4/6] ipaddress: fix ipaddr_flush for Linux >= 3.1 Phil Sutter
2015-11-09 18:51 ` Sergei Shtylyov
2015-11-09 18:58 ` Sergei Shtylyov
2015-11-10 11:21 ` Phil Sutter
2015-11-08 20:22 ` [iproute PATCH v2 5/6] ipaddress: drop unnecessary check in ipaddr_list_flush_or_save() Phil Sutter
2015-11-08 20:22 ` [iproute PATCH v2 6/6] iptoken: simplify iptoken_list a bit Phil Sutter
2015-11-11 11:03 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151123163115.5f8be482@xeon-e3 \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.