All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matt Roper <matthew.d.roper@intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
	intel-gfx@lists.freedesktop.org,
	"Ville Syrjälä" <ville.syrjala@intel.com>
Subject: Re: [PATCH] drm/i915: Disable primary plane if we fail to reconstruct BIOS fb
Date: Mon, 23 Nov 2015 16:10:58 -0800	[thread overview]
Message-ID: <20151124001058.GA16390@intel.com> (raw)
In-Reply-To: <20151123165355.GB22980@nuc-i3427.alporthouse.com>

On Mon, Nov 23, 2015 at 04:53:55PM +0000, Chris Wilson wrote:
> On Mon, Nov 23, 2015 at 08:48:32AM -0800, Matt Roper wrote:
> > If we fail to reconstruct the BIOS fb (e.g., because the FB is too
> > large), we'll be left with plane state that indicates the primary plane
> > is visible yet has a NULL fb.  This mismatch causes problems later on
> > (e.g., for the watermark code).  Since we've failed to reconstruct the
> > BIOS FB, the best solution is to just disable the primary plane and
> > pretend the BIOS never had it enabled.
> > 
> > Cc: Daniel Vetter <daniel@ffwll.ch>
> > Cc: Ville Syrjälä <ville.syrjala@intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> 
> There are a bunch of bugzillas open about this as it is a regression
> from about 3.2.
> -Chris
> 

Do you happen to know any of the bug ID's off the top of your head (or
keywords to look for)?  I skimmed through the bug list, but the only one
that jumped out at me as possibly related is

https://bugs.freedesktop.org/show_bug.cgi?id=91751
("Display still active even though primary plane is disabled and kills
the GPU")

Thanks!


Matt


> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-11-24  0:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-23 16:48 [PATCH] drm/i915: Disable primary plane if we fail to reconstruct BIOS fb Matt Roper
2015-11-23 16:53 ` Chris Wilson
2015-11-24  0:10   ` Matt Roper [this message]
2015-11-24  8:42     ` Chris Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124001058.GA16390@intel.com \
    --to=matthew.d.roper@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.