From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a16Ng-0004wk-PZ for qemu-devel@nongnu.org; Tue, 24 Nov 2015 00:43:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a16Ng-0005Ls-1y for qemu-devel@nongnu.org; Tue, 24 Nov 2015 00:43:08 -0500 Date: Tue, 24 Nov 2015 13:42:59 +0800 From: Fam Zheng Message-ID: <20151124054259.GD26733@ad.usersys.redhat.com> References: <1448342531-16407-1-git-send-email-famz@redhat.com> <1448342531-16407-2-git-send-email-famz@redhat.com> <5653F5F3.10303@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5653F5F3.10303@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Peter Lieven , qemu-devel@nongnu.org, Stefan Hajnoczi , Paolo Bonzini On Mon, 11/23 22:30, Eric Blake wrote: > On 11/23/2015 10:21 PM, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is refering to. It's value should be ignored unless > > s/refering/referring/ > > > BDRV_BLOCK_OFFSET_VALID in ret is set. > > > > Until block drivers fill in the right value, let's clear it explicitly > > right before calling .bdrv_get_block_status. > > > > Signed-off-by: Fam Zheng > > --- > > Reviewed-by: Eric Blake > > Is there ever going to be a need to expose this through QMP, or is this > just used for the qemu-img map subcommand? > I don't think QMP has exposure of information in block address level; for now it is only used by qemu-img map, which has a "json" output format that can be used by upper layer tools. Thanks, Fam