From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Oleg Nesterov <oleg@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Rik van Riel <riel@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] stop_machine: Remove stop_cpus_lock and lg_double_lock/unlock()
Date: Tue, 24 Nov 2015 10:51:56 +0100 [thread overview]
Message-ID: <20151124095156.GP17308@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20151123215339.GF19072@mtj.duckdns.org>
On Mon, Nov 23, 2015 at 04:53:39PM -0500, Tejun Heo wrote:
>
> Isn't this a lot more subtler than the other direction? Unless
> there's a clear performance advantage to removing stopper->lock, using
> lglock for both stop_two and stop_machine seems like an
> easier-to-follow approach to me.
The idea is to kill lglock. There's only two users, this and fs/locks.c
for which I have patches -- which are being benchmarked 'now-ish' :-)
next prev parent reply other threads:[~2015-11-24 9:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 18:11 [PATCH v2 0/1] stop_machine: Remove stop_cpus_lock and lg_double_lock/unlock() Oleg Nesterov
2015-11-21 18:11 ` [PATCH v2 1/1] " Oleg Nesterov
2015-11-23 21:53 ` Tejun Heo
2015-11-24 9:51 ` Peter Zijlstra [this message]
2015-11-24 14:50 ` Tejun Heo
2016-09-22 14:05 ` [tip:locking/core] " tip-bot for Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124095156.GP17308@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=riel@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.