From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 2/3] ASoC: core: add a dapm sink widget
Date: Tue, 24 Nov 2015 15:49:07 +0530 [thread overview]
Message-ID: <20151124101907.GC25173@localhost> (raw)
In-Reply-To: <5654327A.5080406@metafoo.de>
On Tue, Nov 24, 2015 at 10:48:42AM +0100, Lars-Peter Clausen wrote:
> On 11/23/2015 04:52 PM, Vinod Koul wrote:
> > DAPM models various widgets but lacks a sink widget.
> > DSPs can have modules which take audio data, process it and are
> > capable of generating events thus acting as a sink of data.
> >
> > To make the dapm graph complete for such paths we need a dapm
> > sink widget for these modules, so add a SND_SOC_DAPM_SINK to
> > declare such a widget.
> > This widget will be treated as SND_SOC_DAPM_EP_SINK endpoint in
> > the dapm graph
>
> Except for the strange formating of the commit message this looks good.
Checkpath now seems to warn if commit message > 65chars so have set it for
commit message
> Reviewed-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks
--
~Vinod
next prev parent reply other threads:[~2015-11-24 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-23 15:52 [PATCH 0/3] ASoC: core: dapm more updates Vinod Koul
2015-11-23 15:52 ` [PATCH 1/3] ASoC: core: mark SND_SOC_BYTES_EXT as deprecated Vinod Koul
2015-11-25 12:59 ` Applied "ASoC: core: mark SND_SOC_BYTES_EXT as deprecated" to the asoc tree Mark Brown
2015-11-23 15:52 ` [PATCH 2/3] ASoC: core: add a dapm sink widget Vinod Koul
2015-11-24 9:48 ` Lars-Peter Clausen
2015-11-24 10:19 ` Vinod Koul [this message]
2015-11-25 12:51 ` Mark Brown
2015-11-25 12:59 ` Applied "ASoC: dapm: add a dapm sink widget" to the asoc tree Mark Brown
2015-11-23 15:52 ` [PATCH 3/3] ASoC: core: Change power state before rechecking endpoint Vinod Koul
2015-11-23 16:06 ` Lars-Peter Clausen
2015-11-23 17:28 ` Vinod Koul
2015-11-23 18:13 ` Lars-Peter Clausen
2015-11-24 10:17 ` Vinod Koul
2015-11-25 13:00 ` Applied "ASoC: core: Change power state before rechecking endpoint" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124101907.GC25173@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.