From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 0/3] drm/amdgpu: enable DKMS build Date: Tue, 24 Nov 2015 11:33:18 +0100 Message-ID: <20151124103318.GE6149@ulmo> References: <1448355322-3636-1-git-send-email-Jammy.Zhou@amd.com> <20151124085909.GG17050@phenom.ffwll.local> <20151124093623.GB6149@ulmo> <56543707.9090909@vodafone.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1303532920==" Return-path: Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6EEDE6E897 for ; Tue, 24 Nov 2015 02:33:22 -0800 (PST) Received: by pabfh17 with SMTP id fh17so19287375pab.0 for ; Tue, 24 Nov 2015 02:33:22 -0800 (PST) In-Reply-To: <56543707.9090909@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?utf-8?B?S8O2bmln?= Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1303532920== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="MAH+hnPXVZWQ5cD/" Content-Disposition: inline --MAH+hnPXVZWQ5cD/ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 24, 2015 at 11:08:07AM +0100, Christian K=C3=B6nig wrote: > On 24.11.2015 10:36, Thierry Reding wrote: > >On Tue, Nov 24, 2015 at 09:59:09AM +0100, Daniel Vetter wrote: > >>On Tue, Nov 24, 2015 at 04:55:19PM +0800, Jammy Zhou wrote: > >>>This series enable the DKMS build of amdgpu driver. > >>For the curious: What's DKMS? > >I believe in this context it's "Dynamic Kernel Module Support": > > > > https://wiki.debian.org/KernelDKMS >=20 > Yeah, correct. >=20 > > > >I'm somewhat surprised that one would have to do something special to > >the kernel build system to "enable" such a build. But perhaps this is > >completely unrelated. >=20 > I'm a bit torn apart on this. On the one hand I'm not sure if we have > drivers upstream explicitly supporting this as well? It's been a long time since I last used Debian and worked with DKMS, but wasn't the original idea for DKMS to be used on out-of-tree modules? Why the need to build in-tree modules with DKMS? Shouldn't that be done as part of a regular linux-image/linux-modules build? > On the other hand it's just the Makefiles which need to be written in a w= ay > which makes them relocatable. E.g. no absolute path like > drivers/gpu/drm/amd/... in them and that's a good idea anyway. To clarify, I'm not opposing the change, I just thought it weird that the kernel build had to be modified to support an external build system. But in general it seems to be rare that drivers even need to specific additional ccflags, which would explain my surprise. There's precedent for using $(src), see drivers/gpu/drm/Makefile, so I don't see any reason why this would be objectionable. > Maybe just changing the commit message to "don't use absolute paths in the > makefiles" would be sufficient? I don't mind the mention of DKMS either, but perhaps extending the commit message with a few words about what DKMS is and why the change needs to happen (i.e. $(src) used for relocation) would be a good idea anyway. Thierry --MAH+hnPXVZWQ5cD/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJWVDzrAAoJEN0jrNd/PrOhC2oP/1vwZ7zqN1kH7jBFDeE4MHed JNfUU2q3n/QosLn/5SlDLMDbGXzy2OF6Vlsa9dQrLDsfU3N3pso+c/CLUKSUVy5n WB8uIyrjDB3gq0tuicYLRj4ERvMBHThZ6Dqmlm/L1YhwtfzuzcWpm++LlUQGsQcg 6pRnkdThj0yBeXh1ZPuEwPOLiKEgjfNlEY4I6AqJ77uyGfGh1Tex+MPVGlEMZQSa rgV5uPl+A1k+HJqtCsDJsfRww2wn7p2CtP71w6l7N80xb6sEEi8MIFcuLU/O2iGV ISvLBPuyjqMMnlpJj9wznIWv5Fx7hS8pIdgO2uCrArwrThyAypVmqMlZhkFOSGmx o3Y+4ubE0m23aTdO0brK7Q0akCRUXUu4QBTXY5KMShed/+IP2GdeEhQlzEfPIR5R py2OksZIQExTbS7fTmAmqimK1Pezfulv3RWtU+q53V9gCHuWlt8tvKUviXsZ4ROH CkT7iaFTtbis1tXAjCSvJ4Lf9MDaXDaQd9L7b51hX4o4ol24dS+D3r/mlqBwjpYV bbf2OVNQZQoBLSnFr3W5FgyCYVltMlnYzKIQpJUwss7nuEQIHMA4F06dTxZs84SO 9+z6b4jWpeu9quI0vuM4iOIzkEXFi4K5xNGRiI3uQuU6AztB7RtFA38Bu+4SzUz5 3nlc/oKTkHugGI/gckfu =gNgy -----END PGP SIGNATURE----- --MAH+hnPXVZWQ5cD/-- --===============1303532920== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1303532920==--