From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: staging/rdma/hfi1: pre-compute sc and sde for RC/UC QPs Date: Tue, 24 Nov 2015 15:57:55 +0300 Message-ID: <20151124125755.GA7088@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: mike.marciniszyn-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org Hello Mike Marciniszyn, The patch d7b8ba5121e8: "staging/rdma/hfi1: pre-compute sc and sde for RC/UC QPs" from Nov 9, 2015, leads to the following static checker warning: drivers/staging/rdma/hfi1/verbs.c:1657 ah_to_sc() error: buffer overflow 'ibp->sl_to_sc' 32 <= 255 drivers/staging/rdma/hfi1/qp.c 817 if (attr_mask & IB_QP_PATH_MIG_STATE) { 818 qp->s_mig_state = attr->path_mig_state; 819 if (mig) { 820 qp->remote_ah_attr = qp->alt_ah_attr; 821 qp->port_num = qp->alt_ah_attr.port_num; 822 qp->s_pkey_index = qp->s_alt_pkey_index; 823 qp->s_flags |= HFI1_S_AHG_CLEAR; 824 qp->s_sc = ah_to_sc(ibqp->device, &qp->remote_ah_attr); Do we need to verify (hfi1_check_ah(ibqp->device, &qp->remote_ah_attr)) before calling ah_to_sc()? 825 qp->s_sde = qp_to_sdma_engine(qp, qp->s_sc); 826 } 827 } regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html