From: Fam Zheng <famz@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
Peter Lieven <pl@kamp.de>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions
Date: Tue, 24 Nov 2015 21:01:51 +0800 [thread overview]
Message-ID: <20151124130151.GD29832@ad.usersys.redhat.com> (raw)
In-Reply-To: <56545D3A.9000606@redhat.com>
On Tue, 11/24 13:51, Paolo Bonzini wrote:
>
>
> On 24/11/2015 13:50, Fam Zheng wrote:
> > > > + if (bs->file && *file == bs->file->bs &&
> > >
> > > This check is unnecessary, just use "if (file)".
> >
> > "file" would be bs in the case of protocol, and this function will infinitely
> > recurse.
>
> Oh, that's right! But then I think we want to check that and allow
> recursion to any *file, not just bs->file->bs.
>
That makes sense, I'll make it to.
Fam
next prev parent reply other threads:[~2015-11-24 13:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 5:21 [Qemu-devel] [PATCH for-2.6 00/14] qemu-img map: Allow driver to return file of the allocated block Fam Zheng
2015-11-24 5:21 ` [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions Fam Zheng
2015-11-24 5:30 ` Eric Blake
2015-11-24 5:42 ` Fam Zheng
2015-11-24 11:47 ` Paolo Bonzini
2015-11-24 12:50 ` Fam Zheng
2015-11-24 12:51 ` Paolo Bonzini
2015-11-24 13:01 ` Fam Zheng [this message]
2015-11-24 5:21 ` [Qemu-devel] [PATCH for-2.6 02/14] qcow: Assign bs->file->bs to file in qcow_co_get_block_status Fam Zheng
2015-11-24 15:28 ` Eric Blake
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status Fam Zheng
2015-11-24 16:00 ` Eric Blake
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 04/14] raw: Assign bs to file in raw_co_get_block_status Fam Zheng
2015-11-24 16:37 ` Eric Blake
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status Fam Zheng
2015-11-24 18:30 ` Eric Blake
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 08/14] sheepdog: Assign bs to file in sd_co_get_block_status Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 10/14] vpc: Assign bs->file->bs to file in vpc_co_get_block_status Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 11/14] vmdk: Return extent's file in bdrv_get_block_status Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 12/14] qemu-img: In 'map', use QDict to generate JSON output Fam Zheng
2015-11-24 5:42 ` Eric Blake
2015-11-24 6:00 ` Fam Zheng
2015-11-24 11:51 ` Paolo Bonzini
2015-11-24 12:45 ` Markus Armbruster
2015-11-24 13:25 ` Fam Zheng
2015-11-24 13:30 ` Fam Zheng
2015-11-24 13:35 ` Paolo Bonzini
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 13/14] qemu-img: In "map" output, support external file name Fam Zheng
2015-11-24 5:22 ` [Qemu-devel] [PATCH for-2.6 14/14] iotests: Add "qemu-img map" test for VMDK extents Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124130151.GD29832@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.