From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] Fix the order between 2>&1 and >/dev/null
Date: Tue, 24 Nov 2015 15:10:25 +0100 [thread overview]
Message-ID: <20151124141024.GC4151@rei.lan> (raw)
In-Reply-To: <1448346118-24387-2-git-send-email-weijg.fnst@cn.fujitsu.com>
Hi!
> --- a/tools/pounder21/libpounder.sh
> +++ b/tools/pounder21/libpounder.sh
> @@ -1,3 +1,4 @@
> +#!/bin/sh
> # Common shell functions and variables that all pounder scripts can use.
>
> # Copyright (C) 2003-2006 IBM
Is there a reason to add the shebang here? And if there is, the change
should be described in the git commit message.
The rest looks good.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2015-11-24 14:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-24 6:08 [LTP] [PATCH 1/2] kernel/io/disktest: cleanup upon failure occurs Wei Jiangang
2015-11-24 6:08 ` [LTP] [PATCH 2/2] Fix the order between 2>&1 and >/dev/null Wei Jiangang
2015-11-24 6:21 ` [LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs Wei Jiangang
2015-11-24 6:21 ` [LTP] [PATCH v2 2/2] Fix the order between 2>&1 and >/dev/null Wei Jiangang
2015-11-24 14:10 ` Cyril Hrubis [this message]
2015-11-25 1:25 ` Wei, Jiangang
2015-11-25 1:34 ` [LTP] [PATCH v3 1/2] kernel/io/disktest: cleanup upon failure occurs Wei Jiangang
2015-11-25 1:34 ` [LTP] [PATCH v3 2/2] fix the redirection order Wei Jiangang
2015-11-26 12:43 ` Cyril Hrubis
2015-11-24 14:08 ` [LTP] [PATCH v2 1/2] kernel/io/disktest: cleanup upon failure occurs Cyril Hrubis
2015-11-25 1:27 ` Wei, Jiangang
2015-11-24 6:19 ` [LTP] [PATCH " Wei, Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151124141024.GC4151@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.