Re: [PATCH 1/3] drm/i915: Make ibx_{enable, disable}_display_interrupt() static inlines

From: Daniel Vetter <daniel@ffwll.ch>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Make ibx_{enable, disable}_display_interrupt() static inlines
Date: Tue, 24 Nov 2015 18:48:41 +0100	[thread overview]
Message-ID: <20151124174841.GY17050@phenom.ffwll.local> (raw)
In-Reply-To: <1448294777-13722-2-git-send-email-ville.syrjala@linux.intel.com>

On Mon, Nov 23, 2015 at 06:06:15PM +0200, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> No reason why ibx_{enable,disable}_display_interrupt() couldn't be
> static inlines instead of cpp macros.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Not really an opinion on this, but we have this style in a bunch of
places. Anyway:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 15 +++++++++++----
>  1 file changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index a47e0f4fab56..43087d513637 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2756,10 +2756,17 @@ ironlake_disable_display_irq(struct drm_i915_private *dev_priv, u32 mask);
>  void ibx_display_interrupt_update(struct drm_i915_private *dev_priv,
>  				  uint32_t interrupt_mask,
>  				  uint32_t enabled_irq_mask);
> -#define ibx_enable_display_interrupt(dev_priv, bits) \
> -	ibx_display_interrupt_update((dev_priv), (bits), (bits))
> -#define ibx_disable_display_interrupt(dev_priv, bits) \
> -	ibx_display_interrupt_update((dev_priv), (bits), 0)
> +static inline void
> +ibx_enable_display_interrupt(struct drm_i915_private *dev_priv, uint32_t bits)
> +{
> +	ibx_display_interrupt_update(dev_priv, bits, bits);
> +}
> +static inline void
> +ibx_disable_display_interrupt(struct drm_i915_private *dev_priv, uint32_t bits)
> +{
> +	ibx_display_interrupt_update(dev_priv, bits, 0);
> +}
> +
>  
>  /* i915_gem.c */
>  int i915_gem_create_ioctl(struct drm_device *dev, void *data,
> -- 
> 2.4.10
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx