All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt5base: support OVERRIDE_SRCDIR
Date: Wed, 25 Nov 2015 00:06:05 +0100	[thread overview]
Message-ID: <20151124230605.GE3904@free.fr> (raw)
In-Reply-To: <5654EC26.8070401@mind.be>

Arnout, All,

On 2015-11-25 00:00 +0100, Arnout Vandecappelle spake thusly:
> On 24-11-15 23:40, Yann E. MORIN wrote:
> > On 2015-11-24 22:21 +0100, Peter Korsgaard spake thusly:
> >> With OVERRIDE_SRCDIR we don't apply any of the qt5base patches, but the
> >> custom specs files are needed to be able to build - So install these in the
> >> configure step instead of having them as a patch.
> > 
> > IMHO, it make more sense to install them at post-patch (or post-extract)
> > rather than at the beginning of the configure step.
> 
>  But that wouldn't solve the issue, that it is not applied for OVERRIDE_SRCDIR.
> With OVERRIDE_SRCDIR, no extract or patch step is done, instead the rsync step
> is done.

Argh, indeed...

>  We could add it in a POST_PATCH _and_ a POST_RSYNC hook, however.

Yes, that would be better, I think.

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2015-11-24 23:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-24 21:21 [Buildroot] [PATCH] qt5base: support OVERRIDE_SRCDIR Peter Korsgaard
2015-11-24 22:40 ` Yann E. MORIN
2015-11-24 23:00   ` Arnout Vandecappelle
2015-11-24 23:06     ` Yann E. MORIN [this message]
2015-11-25  6:21     ` Peter Korsgaard
2015-11-26 21:01 ` Yann E. MORIN
2015-11-26 21:17 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124230605.GE3904@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.