From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [PATCH for-next V1 5/9] IB/core: Add rdma_network_type to wc Date: Tue, 24 Nov 2015 23:55:42 -0700 Message-ID: <20151125065542.GC4326@obsidianresearch.com> References: <1444925232-13598-1-git-send-email-matanb@mellanox.com> <1444925232-13598-6-git-send-email-matanb@mellanox.com> <20151123211916.GA6062@obsidianresearch.com> <20151124181415.GC10391@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Matan Barak Cc: Matan Barak , Doug Ledford , linux-rdma , Or Gerlitz , Eran Ben Elisha , Somnath Kotur List-Id: linux-rdma@vger.kernel.org On Tue, Nov 24, 2015 at 09:07:41PM +0200, Matan Barak wrote: > IMHO, the user is entitles to choose any valid sgid_index for the > interface. Anything he chooses guaranteed to be valid (from security > perspective) No, the namespace patches will have to limit the sgid_indexes that can be used with a QP to those that fall within the namespace. This is another reason I don't like this approach for the kapi. > Why do we need to block users who use ibv_rc_pingpong and chose the > GID index correctly by hand? I'm not really concerned with user space, we are stuck with exporting the gid index there. > > OK. Change the gid cache so only a RDMA CM private API can return > > rocev2 gids. > > So you propose to block verbs applications from using the RoCE v2 GIDs? Why? Just the kernel consumers, so the in-kernel users are correct. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html