From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 1/2] mmc: mvsdio: delete platform data header Date: Wed, 25 Nov 2015 15:54:09 +0100 Message-ID: <20151125145409.GF11384@lunn.ch> References: <1448459851-32565-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from vps0.lunn.ch ([178.209.37.122]:41426 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750796AbbKYOyM (ORCPT ); Wed, 25 Nov 2015 09:54:12 -0500 Content-Disposition: inline In-Reply-To: <1448459851-32565-1-git-send-email-linus.walleij@linaro.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Linus Walleij Cc: linux-mmc@vger.kernel.org, Chris Ball , Ulf Hansson , Nicolas Pitre , Sebastian Hesselbarth On Wed, Nov 25, 2015 at 02:57:31PM +0100, Linus Walleij wrote: > This platform data struct is only used inside the MVSDIO driver, > nowhere else in the entire kernel. Move the struct into the > driver and delete the external header. > > Cc: Nicolas Pitre > Cc: Andrew Lunn > Cc: Sebastian Hesselbarth > Signed-off-by: Linus Walleij Probably a side effect of moving all kirkwood and Dove devices to device tree. Acked-by: Andrew Lunn Andrew > --- > drivers/mmc/host/mvsdio.c | 7 ++++++- > include/linux/platform_data/mmc-mvsdio.h | 18 ------------------ > 2 files changed, 6 insertions(+), 19 deletions(-) > delete mode 100644 include/linux/platform_data/mmc-mvsdio.h > > diff --git a/drivers/mmc/host/mvsdio.c b/drivers/mmc/host/mvsdio.c > index a448498e3af2..18c70380ea93 100644 > --- a/drivers/mmc/host/mvsdio.c > +++ b/drivers/mmc/host/mvsdio.c > @@ -28,7 +28,6 @@ > > #include > #include > -#include > > #include "mvsdio.h" > > @@ -37,6 +36,12 @@ > static int maxfreq; > static int nodma; > > +struct mvsdio_platform_data { > + unsigned int clock; > + int gpio_card_detect; > + int gpio_write_protect; > +}; > + > struct mvsd_host { > void __iomem *base; > struct mmc_request *mrq; > diff --git a/include/linux/platform_data/mmc-mvsdio.h b/include/linux/platform_data/mmc-mvsdio.h > deleted file mode 100644 > index d02704cd3695..000000000000 > --- a/include/linux/platform_data/mmc-mvsdio.h > +++ /dev/null > @@ -1,18 +0,0 @@ > -/* > - * This file is licensed under the terms of the GNU General Public > - * License version 2. This program is licensed "as is" without any > - * warranty of any kind, whether express or implied. > - */ > - > -#ifndef __MMC_MVSDIO_H > -#define __MMC_MVSDIO_H > - > -#include > - > -struct mvsdio_platform_data { > - unsigned int clock; > - int gpio_card_detect; > - int gpio_write_protect; > -}; > - > -#endif > -- > 2.4.3 >