From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Wed, 25 Nov 2015 10:46:36 -0600 From: Bjorn Helgaas To: Vineet Gupta Cc: Joao Pinto , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "bhelgaas@google.com" , Carlos Palminha , Alexey Brodkin , arcml , Arnd Bergmann Subject: Re: [PATCH 2/2] PCI support added to ARC Message-ID: <20151125164636.GB1380@localhost> References: <9b80d6c1db4d7e2b5ee5dc0056a3d8284e7c2b9b.1448375184.git.jpinto@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: On Wed, Nov 25, 2015 at 05:25:37AM +0000, Vineet Gupta wrote: > On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote: > > + pr_err("PCI: Device %s not available because"/ > > + " of resource collisions\n", pci_name(dev)); > > Better not to break strings - even if they sometime exceed line sz limit of 80. > You could anyways reduce the string content herer. Also use dev_err() instead of pr_err(). From mboxrd@z Thu Jan 1 00:00:00 1970 From: helgaas@kernel.org (Bjorn Helgaas) Date: Wed, 25 Nov 2015 10:46:36 -0600 Subject: [PATCH 2/2] PCI support added to ARC In-Reply-To: References: <9b80d6c1db4d7e2b5ee5dc0056a3d8284e7c2b9b.1448375184.git.jpinto@synopsys.com> List-ID: Message-ID: <20151125164636.GB1380@localhost> To: linux-snps-arc@lists.infradead.org On Wed, Nov 25, 2015@05:25:37AM +0000, Vineet Gupta wrote: > On Tuesday 24 November 2015 08:02 PM, Joao Pinto wrote: > > + pr_err("PCI: Device %s not available because"/ > > + " of resource collisions\n", pci_name(dev)); > > Better not to break strings - even if they sometime exceed line sz limit of 80. > You could anyways reduce the string content herer. Also use dev_err() instead of pr_err().