From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits Date: Wed, 25 Nov 2015 18:35:21 +0100 Message-ID: <20151125173521.GC4227@pd.tnic> References: <1448466589-9407-1-git-send-email-ehabkost@redhat.com> <1448466589-9407-4-git-send-email-ehabkost@redhat.com> <20151125172152.GB4227@pd.tnic> <5655EFF5.6030000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: Eduardo Habkost , qemu-devel@nongnu.org, Marcelo Tosatti , kvm@vger.kernel.org, ying.huang@intel.com, Andreas =?utf-8?Q?F=C3=A4rber?= , Richard Henderson To: Paolo Bonzini Return-path: Received: from mail.skyhub.de ([78.46.96.112]:40173 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255AbbKYRfX (ORCPT ); Wed, 25 Nov 2015 12:35:23 -0500 Content-Disposition: inline In-Reply-To: <5655EFF5.6030000@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Nov 25, 2015 at 06:29:25PM +0100, Paolo Bonzini wrote: > On 25/11/2015 18:21, Borislav Petkov wrote: > >> Instead of silently clearing mcg_cap bits when the host doesn't > >> > support them, print a warning when doing that. > > Why the host? Why would we want there to be any relation between the MCA > > capabilities of the host and what qemu is emulating? > > He means the hypervisor. :) Ah, ok. :) Then they look good to me, a step in the right direction. Acked-by: Borislav Petkov Thanks! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dyb-0005VQ-6r for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:35:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a1dyV-0003zw-VL for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:35:29 -0500 Received: from mail.skyhub.de ([2a01:4f8:120:8448::d00d]:60279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a1dyV-0003ze-Pm for qemu-devel@nongnu.org; Wed, 25 Nov 2015 12:35:23 -0500 Date: Wed, 25 Nov 2015 18:35:21 +0100 From: Borislav Petkov Message-ID: <20151125173521.GC4227@pd.tnic> References: <1448466589-9407-1-git-send-email-ehabkost@redhat.com> <1448466589-9407-4-git-send-email-ehabkost@redhat.com> <20151125172152.GB4227@pd.tnic> <5655EFF5.6030000@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5655EFF5.6030000@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/3] target-i386: kvm: Print warning when clearing mcg_cap bits List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Eduardo Habkost , kvm@vger.kernel.org, Marcelo Tosatti , qemu-devel@nongnu.org, ying.huang@intel.com, Andreas =?utf-8?Q?F=C3=A4rber?= , Richard Henderson On Wed, Nov 25, 2015 at 06:29:25PM +0100, Paolo Bonzini wrote: > On 25/11/2015 18:21, Borislav Petkov wrote: > >> Instead of silently clearing mcg_cap bits when the host doesn't > >> > support them, print a warning when doing that. > > Why the host? Why would we want there to be any relation between the MCA > > capabilities of the host and what qemu is emulating? > > He means the hypervisor. :) Ah, ok. :) Then they look good to me, a step in the right direction. Acked-by: Borislav Petkov Thanks! -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.