From mboxrd@z Thu Jan 1 00:00:00 1970 From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk) Date: Wed, 25 Nov 2015 15:44:30 -0500 Subject: [Cocci] [Xen-devel] [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set() In-Reply-To: <20151125193651.GH9528@wotan.suse.de> References: <1448041672-3986-1-git-send-email-mcgrof@do-not-panic.com> <1448041672-3986-3-git-send-email-mcgrof@do-not-panic.com> <20151125145322.GA24630@x230.dumpdata.com> <20151125193651.GH9528@wotan.suse.de> Message-ID: <20151125204420.GA20267@x230.dumpdata.com> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr On Wed, Nov 25, 2015 at 08:36:51PM +0100, Luis R. Rodriguez wrote: > On Wed, Nov 25, 2015 at 09:53:27AM -0500, Konrad Rzeszutek Wilk wrote: > > On Fri, Nov 20, 2015 at 09:47:45AM -0800, Luis R. Rodriguez wrote: > > > From: "Luis R. Rodriguez" > > > > > > Using deprecate gnutls_*_set() triggers a failure to compile > > > with gnutls30-3.4.4, used on OpenSUSE factory: > > > > > > ../libqemu_common.a(vnc.o): In function `vnc_start_tls': > > > ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2164: undefined reference to `gnutls_kx_set_priority' > > > ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2171: undefined reference to `gnutls_certificate_type_set_priority' > > > ~/devel/xen/tools/qemu-xen-traditional-dir/vnc.c:2178: undefined reference to `gnutls_protocol_set_priority' > > > > > > This compilation issue can be fixed by using the new routine > > > gnutls_priority_set_direct() which replaces the deprecated calls > > > which also simplifies the code considerably. > > > > > > Thanks for posting that! It certainly fixes that issue. > > Acked-by? Tested-by: Konrad Rzeszutek Wilk > > > I was wondering if you had seen these as well: > > > > /home/konrad/qemu-trad.git/vnc.c:1929:1: warning: > > ?gnutls_anon_server_credentials? is deprecated > > [-Wdeprecated-declarations] > > { > > ^ > > /home/konrad/qemu-trad.git/vnc.c: In function > > ?vnc_tls_initialize_anon_cred?: > > /home/konrad/qemu-trad.git/vnc.c:1930:5: warning: > > ?gnutls_anon_server_credentials? is deprecated > > [-Wdeprecated-declarations] > > gnutls_anon_server_credentials anon_cred; > > ^ > > /home/konrad/qemu-trad.git/vnc.c: In function ?vnc_start_tls?: > > /home/konrad/qemu-trad.git/vnc.c:2203:6: warning: > > ?gnutls_anon_server_credentials? is deprecated > > [-Wdeprecated-declarations] > > gnutls_anon_server_credentials anon_cred = > > vnc_tls_initialize_anon_cred(); > > ^ > > ? > > > > (This is Fedora 23) > > Nope. > > Luis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 2/9] Use gnutls_priority_set_direct() to deprecate gnutls_*_set() Date: Wed, 25 Nov 2015 15:44:30 -0500 Message-ID: <20151125204420.GA20267@x230.dumpdata.com> References: <1448041672-3986-1-git-send-email-mcgrof@do-not-panic.com> <1448041672-3986-3-git-send-email-mcgrof@do-not-panic.com> <20151125145322.GA24630@x230.dumpdata.com> <20151125193651.GH9528@wotan.suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20151125193651.GH9528@wotan.suse.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Luis R. Rodriguez" Cc: xen-devel@lists.xensource.com, ian.campbell@citrix.com, "Luis R. Rodriguez" , pryorm09@gmail.com, cfergeau@redhat.com, JBeulich@suse.com, samuel.thibault@ens-lyon.org, cocci@systeme.lip6.fr List-Id: xen-devel@lists.xenproject.org T24gV2VkLCBOb3YgMjUsIDIwMTUgYXQgMDg6MzY6NTFQTSArMDEwMCwgTHVpcyBSLiBSb2RyaWd1 ZXogd3JvdGU6Cj4gT24gV2VkLCBOb3YgMjUsIDIwMTUgYXQgMDk6NTM6MjdBTSAtMDUwMCwgS29u cmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+ID4gT24gRnJpLCBOb3YgMjAsIDIwMTUgYXQgMDk6 NDc6NDVBTSAtMDgwMCwgTHVpcyBSLiBSb2RyaWd1ZXogd3JvdGU6Cj4gPiA+IEZyb206ICJMdWlz IFIuIFJvZHJpZ3VleiIgPG1jZ3JvZkBzdXNlLmNvbT4KPiA+ID4gCj4gPiA+IFVzaW5nIGRlcHJl Y2F0ZSBnbnV0bHNfKl9zZXQoKSB0cmlnZ2VycyBhIGZhaWx1cmUgdG8gY29tcGlsZQo+ID4gPiB3 aXRoIGdudXRsczMwLTMuNC40LCB1c2VkIG9uIE9wZW5TVVNFIGZhY3Rvcnk6Cj4gPiA+IAo+ID4g PiAuLi9saWJxZW11X2NvbW1vbi5hKHZuYy5vKTogSW4gZnVuY3Rpb24gYHZuY19zdGFydF90bHMn Ogo+ID4gPiB+L2RldmVsL3hlbi90b29scy9xZW11LXhlbi10cmFkaXRpb25hbC1kaXIvdm5jLmM6 MjE2NDogdW5kZWZpbmVkIHJlZmVyZW5jZSB0byBgZ251dGxzX2t4X3NldF9wcmlvcml0eScKPiA+ ID4gfi9kZXZlbC94ZW4vdG9vbHMvcWVtdS14ZW4tdHJhZGl0aW9uYWwtZGlyL3ZuYy5jOjIxNzE6 IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYGdudXRsc19jZXJ0aWZpY2F0ZV90eXBlX3NldF9wcmlv cml0eScKPiA+ID4gfi9kZXZlbC94ZW4vdG9vbHMvcWVtdS14ZW4tdHJhZGl0aW9uYWwtZGlyL3Zu Yy5jOjIxNzg6IHVuZGVmaW5lZCByZWZlcmVuY2UgdG8gYGdudXRsc19wcm90b2NvbF9zZXRfcHJp b3JpdHknCj4gPiA+IAo+ID4gPiBUaGlzIGNvbXBpbGF0aW9uIGlzc3VlIGNhbiBiZSBmaXhlZCBi eSB1c2luZyB0aGUgbmV3IHJvdXRpbmUKPiA+ID4gZ251dGxzX3ByaW9yaXR5X3NldF9kaXJlY3Qo KSB3aGljaCByZXBsYWNlcyB0aGUgZGVwcmVjYXRlZCBjYWxscwo+ID4gPiB3aGljaCBhbHNvIHNp bXBsaWZpZXMgdGhlIGNvZGUgY29uc2lkZXJhYmx5Lgo+ID4gCj4gPiAKPiA+IFRoYW5rcyBmb3Ig cG9zdGluZyB0aGF0ISBJdCBjZXJ0YWlubHkgZml4ZXMgdGhhdCBpc3N1ZS4KPiAKPiBBY2tlZC1i eT8KClRlc3RlZC1ieTogS29ucmFkIFJ6ZXN6dXRlayBXaWxrIDxrb25yYWQud2lsa0BvcmFjbGUu Y29tPgo+IAo+ID4gSSB3YXMgd29uZGVyaW5nIGlmIHlvdSBoYWQgc2VlbiB0aGVzZSBhcyB3ZWxs Ogo+ID4gCj4gPiAvaG9tZS9rb25yYWQvcWVtdS10cmFkLmdpdC92bmMuYzoxOTI5OjE6IHdhcm5p bmc6Cj4gPiDigJhnbnV0bHNfYW5vbl9zZXJ2ZXJfY3JlZGVudGlhbHPigJkgaXMgZGVwcmVjYXRl ZAo+ID4gWy1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnNdCj4gPiAgewo+ID4gIF4KPiA+IC9ob21l L2tvbnJhZC9xZW11LXRyYWQuZ2l0L3ZuYy5jOiBJbiBmdW5jdGlvbgo+ID4g4oCYdm5jX3Rsc19p bml0aWFsaXplX2Fub25fY3JlZOKAmToKPiA+IC9ob21lL2tvbnJhZC9xZW11LXRyYWQuZ2l0L3Zu Yy5jOjE5MzA6NTogd2FybmluZzoKPiA+IOKAmGdudXRsc19hbm9uX3NlcnZlcl9jcmVkZW50aWFs c+KAmSBpcyBkZXByZWNhdGVkCj4gPiBbLVdkZXByZWNhdGVkLWRlY2xhcmF0aW9uc10KPiA+ICAg ICAgZ251dGxzX2Fub25fc2VydmVyX2NyZWRlbnRpYWxzIGFub25fY3JlZDsKPiA+ICAgICAgXgo+ ID4gL2hvbWUva29ucmFkL3FlbXUtdHJhZC5naXQvdm5jLmM6IEluIGZ1bmN0aW9uIOKAmHZuY19z dGFydF90bHPigJk6Cj4gPiAvaG9tZS9rb25yYWQvcWVtdS10cmFkLmdpdC92bmMuYzoyMjAzOjY6 IHdhcm5pbmc6Cj4gPiDigJhnbnV0bHNfYW5vbl9zZXJ2ZXJfY3JlZGVudGlhbHPigJkgaXMgZGVw cmVjYXRlZAo+ID4gWy1XZGVwcmVjYXRlZC1kZWNsYXJhdGlvbnNdCj4gPiAgICAgICBnbnV0bHNf YW5vbl9zZXJ2ZXJfY3JlZGVudGlhbHMgYW5vbl9jcmVkID0KPiA+IHZuY190bHNfaW5pdGlhbGl6 ZV9hbm9uX2NyZWQoKTsKPiA+ICAgICAgIF4KPiA+ID8KPiA+IAo+ID4gKFRoaXMgaXMgRmVkb3Jh IDIzKQo+IAo+IE5vcGUuCj4gCj4gIEx1aXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3Rz Lnhlbi5vcmcKaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==