From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Weiner Subject: Re: [PATCH v2] drm/i915: Disable shrinker for non-swapped backed objects Date: Wed, 25 Nov 2015 15:46:35 -0500 Message-ID: <20151125204635.GA14536@cmpxchg.org> References: <20151124231738.GA15770@nuc-i3427.alporthouse.com> <1448476616-5257-1-git-send-email-chris@chris-wilson.co.uk> <20151125190610.GA12238@cmpxchg.org> <20151125203102.GJ22980@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from gum.cmpxchg.org (gum.cmpxchg.org [85.214.110.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9DA5B6EB31 for ; Wed, 25 Nov 2015 12:46:43 -0800 (PST) Content-Disposition: inline In-Reply-To: <20151125203102.GJ22980@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson Cc: linux-mm@kvack.org, intel-gfx@lists.freedesktop.org, sourab.gupta@intel.com, Akash Goel List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBOb3YgMjUsIDIwMTUgYXQgMDg6MzE6MDJQTSArMDAwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFdlZCwgTm92IDI1LCAyMDE1IGF0IDAyOjA2OjEwUE0gLTA1MDAsIEpvaGFubmVz IFdlaW5lciB3cm90ZToKPiA+IE9uIFdlZCwgTm92IDI1LCAyMDE1IGF0IDA2OjM2OjU2UE0gKzAw MDAsIENocmlzIFdpbHNvbiB3cm90ZToKPiA+ID4gK3N0YXRpYyBib29sIHN3YXBfYXZhaWxhYmxl KHZvaWQpCj4gPiA+ICt7Cj4gPiA+ICsJcmV0dXJuIHRvdGFsX3N3YXBfcGFnZXMgfHwgZnJvbnRz d2FwX2VuYWJsZWQ7Cj4gPiA+ICt9Cj4gPiAKPiA+IElmIHlvdSB1c2UgZ2V0X25yX3N3YXBfcGFn ZXMoKSBpbnN0ZWFkIG9mIHRvdGFsX3N3YXBfcGFnZXMsIHRoaXMgd2lsbAo+ID4gYWxzbyBzdG9w IHNjYW5uaW5nIG9iamVjdHMgb25jZSB0aGUgc3dhcCBzcGFjZSBpcyBmdWxsLiBXZSBkbyB0aGF0 IGluCj4gPiB0aGUgVk0gdG8gc3RvcCBzY2FubmluZyBhbm9ueW1vdXMgcGFnZXMuCj4gCj4gVGhh bmtzLiBXb3VsZCBFWFBPUlRfU1lNQk9MX0dQTChucl9zd2FwX3BhZ2VzKSAob3IgZXF1aXZhbGVu dCkgYmUKPiBhY2NlcHRhYmxlPwoKTm8gb3Bwb3NpdGlvbiBmcm9tIG1lLiBKdXN0IHBsZWFzZSBh ZGQgYSBzbWFsbCBjb21tZW50IHRoYXQgdGhpcyBpcwpmb3Igc2hyaW5rZXJzIHdpdGggc3dhcHBh YmxlIG9iamVjdHMuCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by kanga.kvack.org (Postfix) with ESMTP id AD9396B0255 for ; Wed, 25 Nov 2015 15:46:45 -0500 (EST) Received: by wmec201 with SMTP id c201so3656446wme.0 for ; Wed, 25 Nov 2015 12:46:45 -0800 (PST) Received: from gum.cmpxchg.org (gum.cmpxchg.org. [85.214.110.215]) by mx.google.com with ESMTPS id 72si8114187wmt.121.2015.11.25.12.46.44 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Nov 2015 12:46:44 -0800 (PST) Date: Wed, 25 Nov 2015 15:46:35 -0500 From: Johannes Weiner Subject: Re: [PATCH v2] drm/i915: Disable shrinker for non-swapped backed objects Message-ID: <20151125204635.GA14536@cmpxchg.org> References: <20151124231738.GA15770@nuc-i3427.alporthouse.com> <1448476616-5257-1-git-send-email-chris@chris-wilson.co.uk> <20151125190610.GA12238@cmpxchg.org> <20151125203102.GJ22980@nuc-i3427.alporthouse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151125203102.GJ22980@nuc-i3427.alporthouse.com> Sender: owner-linux-mm@kvack.org List-ID: To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org, linux-mm@kvack.org, Akash Goel , sourab.gupta@intel.com On Wed, Nov 25, 2015 at 08:31:02PM +0000, Chris Wilson wrote: > On Wed, Nov 25, 2015 at 02:06:10PM -0500, Johannes Weiner wrote: > > On Wed, Nov 25, 2015 at 06:36:56PM +0000, Chris Wilson wrote: > > > +static bool swap_available(void) > > > +{ > > > + return total_swap_pages || frontswap_enabled; > > > +} > > > > If you use get_nr_swap_pages() instead of total_swap_pages, this will > > also stop scanning objects once the swap space is full. We do that in > > the VM to stop scanning anonymous pages. > > Thanks. Would EXPORT_SYMBOL_GPL(nr_swap_pages) (or equivalent) be > acceptable? No opposition from me. Just please add a small comment that this is for shrinkers with swappable objects. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org