Re: [Qemu-devel] [PATCH v3 0/4] Bitmap clean-up patches for 2.6

[Fam Zheng <famz@redhat.com>]

On Wed, 11/25 09:57, Vladimir Sementsov-Ogievskiy wrote:
> Hmm, stop. Very bad thing (sorry, that I didn't realize it before):
> 
> This breaks my dirty bitmap migration series with its meta bitmaps.
> Meta bitmap is an additional HBitmap in BdrvDirtyBitmap, which
> tracks dirtiness of this BdrvDirtyBitmap. And it (meta bitmap) have
> its own granularity of course. Or we will have to maintain
> additional meta_gran_shift and lots of duplicated code..
> 
> If we speak about splitting granularity out of HBitmap, then the
> most true way should be
> 
> struct HBitmapGranuled {
>   struct HBitmap *hb;
>   uint32_t gran_shift;
> }
> 
> with all supporting functions and iterators.

Then it's not worth making this change, let's drop patch 3 & 4 for now.

Fam