Re: [PATCH 1/4] efi: expose non-blocking set_variable() wrapper to efivars

[Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>]

On Thu, 19 Nov, at 02:36:28PM, Ard Biesheuvel wrote:
> Commit 6d80dba1c9fe ("efi: Provide a non-blocking SetVariable()
> operation") implemented a non-blocking alternative for the UEFI
> SetVariable() invocation performed by efivars, since it may occur
> in atomic context. However, this version of the function was never
> exposed via the efivars struct, so the non-blocking versions was
> not actually callable. Fix that.
> 
> Fixes: 6d80dba1c9fe ("efi: Provide a non-blocking SetVariable() operation")
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>  drivers/firmware/efi/efi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/efi/efi.c b/drivers/firmware/efi/efi.c
> index 027ca212179f..3b52677f459a 100644
> --- a/drivers/firmware/efi/efi.c
> +++ b/drivers/firmware/efi/efi.c
> @@ -180,6 +180,7 @@ static int generic_ops_register(void)
>  {
>  	generic_ops.get_variable = efi.get_variable;
>  	generic_ops.set_variable = efi.set_variable;
> +	generic_ops.set_variable_nonblocking = efi.set_variable_nonblocking;
>  	generic_ops.get_next_variable = efi.get_next_variable;
>  	generic_ops.query_variable_store = efi_query_variable_store;
>  

What a mess. Thanks for the fix Ard.