From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v9 1/9] nfp: basic initialization
Date: Thu, 26 Nov 2015 10:14:49 -0800
Message-ID: <20151126101449.3f450a14@xeon-e3>
References: <1448531369-8808-1-git-send-email-alejandro.lucero@netronome.com>
 <1448531369-8808-2-git-send-email-alejandro.lucero@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Alejandro Lucero <alejandro.lucero@netronome.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com
 [209.85.220.51]) by dpdk.org (Postfix) with ESMTP id 79F319238
 for <dev@dpdk.org>; Thu, 26 Nov 2015 19:14:49 +0100 (CET)
Received: by padhx2 with SMTP id hx2so92000734pad.1
 for <dev@dpdk.org>; Thu, 26 Nov 2015 10:14:48 -0800 (PST)
In-Reply-To: <1448531369-8808-2-git-send-email-alejandro.lucero@netronome.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 26 Nov 2015 09:49:21 +0000
Alejandro Lucero <alejandro.lucero@netronome.com> wrote:

> +static inline void
> +nfp_qcp_ptr_add(__u8 *q, enum nfp_qcp_ptr ptr, uint32_t val)
> +{
> +	uint32_t off;

Minor nit. why mix use of Linux specific basic size typedefs (__u8)
with Posix standard values (uint32_t). The DPDK style is to use
the Posix types except in kernel drivers or code that is coming
from unified drivers (ie ixgbe/base)