From: Cyril Hrubis <chrubis@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2] hugetlb: checking if hugepage is supported on target system
Date: Thu, 26 Nov 2015 14:49:08 +0100 [thread overview]
Message-ID: <20151126134908.GA9276@rei.lan> (raw)
In-Reply-To: <CAEemH2cUXFEMk1MXt=-eyjc3s0sinn4X2J89CxPmyKy5uZr3uw@mail.gmail.com>
Hi!
> > forgot "static"?
> >
>
> no, it will be conflict with the prototype in mem.h and get compiler error
> like:
> -------
> hugemmap05.c:253: error: static declaration of ???cleanup??? follows non-static
> declaration
> /mnt/tests/kernel/distribution/ltp/generic/ltp-full-20150903/testcases/kernel/mem/include/mem.h:100:
> note: previous declaration of ???cleanup??? was here
> hugemmap05.c:295: error: static declaration of ???setup??? follows non-static
> declaration
> /mnt/tests/kernel/distribution/ltp/generic/ltp-full-20150903/testcases/kernel/mem/include/mem.h:101:
> note: previous declaration of ???setup??? was here
> make: *** [hugemmap05] Error 1
Why have you added the function into the mem/include/mem.h in the first
place? There is kernel/mem/hugetlb/lib/ directory allready, just make
use of it.
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2015-11-26 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 2:57 [LTP] [PATCH v2] hugetlb: checking if hugepage is supported on target system Li Wang
2015-11-26 8:47 ` Alexey Kodanev
2015-11-26 9:00 ` Li Wang
2015-11-26 13:49 ` Cyril Hrubis [this message]
2015-11-27 5:32 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151126134908.GA9276@rei.lan \
--to=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.