Re: [Qemu-devel] [PATCH v2 0/8] Add basic "detach" support for dump-guest-memory

[Fam Zheng <famz@redhat.com>]

On Fri, 11/27 10:48, Peter Xu wrote:
> Sorry that this v2 series cannot be aligned with the v1 series. One
> patch is added at the begining of the series to do some code
> cleanups (also fix potential memory leak). Meanwhile, several new
> patches are appended to the v1 series. Please see the change log for
> more info.

Looks good overall! I've replied patches with a few questions. Thanks!

Fam

> 
> v2 changes:
> - fixed English errors [Drew]
> - reordered the "detach" field, first make it optional, then make sure
>   it's order is consistent [Drew, Fam]
> - added doc for new detach flag [Eric]
> - collected error msg even detached [Drew]
> - added qmp event DUMP_COMPLETED to notify user [Eric, Fam]
> - added "dump-query" QMP & HMP commands to query dump status [Eric]
> - "stop" is not allowed when dump in background (also include
>   "cont" and "dump-guest-memory") [Fam]
> - added codes to calculate how many dump work finished, which could
>   be queried from "dump-query" [Laszlo]
> - added list to track all used MemoryRegion objects, also ref before
>   use [Paolo]
> - dump-guest-memory will be forbidden during incoming migrate [Paolo]
> - taking rcu lock when collecting memory info [Paolo]
> 
> Test Done:
> - QMP & HMP
>   - test default dump (sync), work as usual
>   - test detached dump, command return immediately. When dump
>     finished, will receive event DUMP_COMPLETED with a message. 
>   - test dump-query before/during/after dump
>   - test kdump with zlib compression, w/ and w/o detach
> - libvirt
>   - test "virsh dump --memory-only" with default format and
>     kdump-zlib format, work as usual
> 
> Peter Xu (8):
>   dump-guest-memory: cleanup: removing dump_{error|cleanup}().
>   dump-guest-memory: add "detach" flag for QMP/HMP interfaces.
>   dump-guest-memory: add basic "detach" support.
>   dump-guest-memory: add qmp event DUMP_COMPLETED
>   dump-query: add "dump-query" command to query dump status
>   dump-query: implement "status" of "dump-query" command.
>   DumpState: adding total_size and written_size fields
>   dump-query: make the percentage accurate.
> 
>  docs/qmp-events.txt             |  12 ++
>  dump.c                          | 284 ++++++++++++++++++++++++++++++++--------
>  hmp-commands.hx                 |  20 ++-
>  hmp.c                           |  18 ++-
>  hmp.h                           |   1 +
>  include/qemu-common.h           |   8 ++
>  include/sysemu/dump.h           |  28 ++++
>  include/sysemu/memory_mapping.h |   8 ++
>  memory_mapping.c                |  46 ++++++-
>  qapi-schema.json                |  29 +++-
>  qapi/event.json                 |  10 ++
>  qmp-commands.hx                 |  35 ++++-
>  qmp.c                           |  14 ++
>  13 files changed, 450 insertions(+), 63 deletions(-)
> 
> -- 
> 2.4.3
> 
>