From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/2] drm: Avoid calling the cursor_set2 callback from the drm_mode_cursor ioctl Date: Fri, 27 Nov 2015 14:02:48 +0200 Message-ID: <20151127120248.GL4437@intel.com> References: <1448563935-3157-1-git-send-email-thellstrom@vmware.com> <20151127101133.GW17050@phenom.ffwll.local> <56584197.3020707@vmware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 51FBE6E7E7 for ; Fri, 27 Nov 2015 04:02:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <56584197.3020707@vmware.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thomas Hellstrom Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMjcsIDIwMTUgYXQgMTI6NDI6MTVQTSArMDEwMCwgVGhvbWFzIEhlbGxzdHJv bSB3cm90ZToKPiBPbiAxMS8yNy8yMDE1IDExOjExIEFNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ ID4gT24gVGh1LCBOb3YgMjYsIDIwMTUgYXQgMTA6NTI6MTRBTSAtMDgwMCwgVGhvbWFzIEhlbGxz dHJvbSB3cm90ZToKPiA+PiBJZiB0aGUgZHJtX21vZGVfY3Vyc29yX2lvY3RsIGlzIGNhbGxlZCBh bmQgdGhlIGN1cnNvcl9zZXQyIGNhbGxiYWNrIGlzCj4gPj4gaW1wbGVtZW50ZWQsIHRoZSBjdXJz b3IgaG90c3BvdCBpcyBzZXQgdG8gKDAsMCkgd2hpY2ggaXMgaW5jb21wYXRpYmxlCj4gPj4gd2l0 aCB2bXdnZnggd2hlcmUgdGhlIGhvdHNwb3Qgc2hvdWxkIGluc3RlYWQgcmVtYWluIHVuY2hhbmdl ZC4KPiA+Pgo+ID4+IFNvIGlmIHRoZSBkcml2ZXIgaW1wbGVtZW50cyBib3RoIGN1cnNvcl9zZXQy IGFuZCBjdXJzb3Jfc2V0LCBwcmVmZXIgY2FsbGluZwo+ID4+IHRoZSBsYXR0ZXIgZnJvbSB0aGUg ZHJtX21vZGVfY3Vyc29yIGlvY3RsLgo+ID4+Cj4gPj4gU2lnbmVkLW9mZi1ieTogVGhvbWFzIEhl bGxzdHJvbSA8dGhlbGxzdHJvbUB2bXdhcmUuY29tPgo+ID4gVGhhdCBsb29rcyBsaWtlIHBhcGVy aW5nIG92ZXIgYSBidWcgaW4gdGhlIGNsaWVudCAtIGl0IHNpbXBseSBzaG91bGRuJ3QKPiA+IG1p eCB0aGVzZSB0d28gaWYgaXQgZXhwZWN0cyB0aGUgaG90c3BvdCB0byBzdGljayBhcm91bmQuIFRo ZXJlIHdhcyBhbHNvCj4gPiByZWNlbnRseSBhIGJpZyBkaXNjdXNzaW9uIGFib3V0IGhvdHNwb3Qg YmVoYXZpb3VyLCBhbmQgdGhlIGNvbmNsdXNpb24gd2FzCj4gPiB0aGF0IHF4bCBnb3QgaXQgYWxs IHdyb25nLiBTaW5jZSB0aGF0IHdhcyBzcGVjaWZpY2FsbHkgYWRkZWQgZm9yIHF4bCBJJ20KPiA+ IG5vdCBzdXJlIGhvdyB3ZWxsIHRoaXMgd2FzIGV2ZXIgdGVzdGVkIC4uLgo+IAo+IE5vLCB0aGlz IGlzIG5vdCB0aGUgY2FzZSwgVGhpcyBpcyBmb3Igb2xkIFhvcmcgdXNlcnNwYWNlIHRoYXQgZmly c3Qgc2V0cwo+IHRoZSBob3RzcG90IHVzaW5nIG91ciBhbmNpZW50Cj4gZHJpdmVyLXByaXZhdGUg aW9jdGwgYW5kIHRoZW4gY2FsbHMgZHJtX21vZGVfY3Vyc29yKCkgdG8gdXBkYXRlIHRoZSBjdXJz b3IuCj4gCj4gTm93IGlmIHdlIHdlcmUgdG8gaW1wbGVtZW50IGN1cnNvcl9zZXQyLCB3aGljaCBp cyBhcHBhcmVudGx5IG5lZWRlZCB0bwo+IGdldCBnbm9tZS1zaGVsbC9XYXlsYW5kIGN1cnNvcnMg aW4gdGhlIHJpZ2h0IHBsYWNlLCB3aXRob3V0IHRoaXMgZml4LCBpdAo+IHdvdWxkIGJyZWFrIG9s ZCBYb3JnLCBzbyB3ZSBkb24ndCBoYXZlIG11Y2ggY2hvaWNlIGluIHRoaXMgY2FzZSBmcm9tCj4g d2hhdCBJIGNhbiB0ZWxsLgo+IAo+IFRoZSByb290IHByb2JsZW0gaGVyZSBpcyB0aGF0IHRoZSBk cm1fbW9kZV9jdXJzb3IoKSBiZWhhdmlvdXIgaW4gdGhlCj4gcHJlc2VuY2Ugb2YgY3Vyc29yX3Nl dDIgZGlkbid0IHRha2UgdGhlIGV4aXN0aW5nIHZtd2FyZSBob3RzcG90Cj4gc2VtYW50aWNzIGlu dG8gYWNjb3VudC4KPiAKPiA+IFRoZSBvdGhlciBwcm9ibGVtIHNlZW1zIHRvIGJlIHRoYXQgWCBp cyByYWN5IHdpdGggdXBkYXRpbmcgY3Vyc29ycyAoc2luY2UKPiA+IGl0IGRvZXMgYSBzZXRQb3Mg YW5kIHNldEN1cnNvciBzZXBhcmF0ZWx5LCBkZXNwaXRlIHRoYXQgdGhpcyBpb2N0bCBjYW4gZG8K PiA+IGl0IGluIG9uZSBnbykgYW5kIHNvIGlmIHlvdSBtb3ZlIHRoZSBob3RzcG90IHlvdSBnZXQg YSBqdW1weSBjdXJzb3IuCj4gPiBSYWRlb24gdHJpZWQgdG8gcGFwZXIgb3ZlciB0aGF0IGJ1dCBm dW5kYW1lbnRhbGx5IHlvdSBuZWVkIHRvIGZpeCBYIGFuZAo+ID4gdXNlIGF0b21pYyAob3IgYXQg bGVhc3QgdW5pdmVyc2FsIHBsYW5lIGN1cnNvciBzdXBwb3J0KSB0byBmaXggdGhpcy4KPiA+Cj4g PiBHaXZlbiBhbGwgdGhhdCBJJ20gbGVhbmluZyB0b3dhcmRzICJ0aGUgZnV0dXJlIGlzIGF0b21p YyIsIGxldCdzIHBsZWFzZQo+ID4gbm90IGFkZCBoYWNrcyB0byBsZWdhY3kgY29kZS4gQXNpZGU6 IEF0b21pYyBkb2Vzbid0IGhhdmUgdGhlIGhvdHNwb3QteC95Cj4gPiBwcm9wZXJ0aWVzIHlldCwg YnV0IHJlYWxseSB0aGUgb25seSByZWFzb24gd2FzIHRoYXQgd2UgZG9uJ3QgeWV0IGhhdmUgYW4K PiA+IGF0b21pYyBkcml2ZXIgbmVlZGluZyB0aGVtLiBBZGRpbmcgdGhvc2UgcHJvcHMgd2lsbCBi ZSBhIHRpbnkgcGF0Y2ggb2YgYQo+ID4gZmV3IGxpbmVzLgo+IAo+IFNpbmNsYWlyIGhhcyBzdGFy dGVkIHdvcmtpbmcgb24gYXRvbWljIHN1cHBvcnQgZm9yIHZtd2dmeCwgYnV0IHdlIHJlYWxseQo+ IG5lZWQgdG8gZml4IHRoaXMgYWxzbyBpbgo+IHRoZSBsZWdhY3kgY29kZSwgdWdseSBvciBub3Qu CgpJIHdhcyB0aGlua2luZyBtYXliZSBpdCB3b3VsZCBiZSBjbGVhbmVyIHRvIG5vdCByZXNldCB0 aGUgaG90c3BvdCB0bwowLDAgaW4gZHJtX21vZGVfY3Vyc29yX2lvY3RsKCkgYW5kIGluc3RlYWQg a2VlcCB3aGF0IHdhcyBwcmV2aW91c2x5CmNvbmZpZ3VyZWQsIGFuZCBvbmx5IGRvIHRoZSByZXNl dCB0byAwLDAgaW4gbGFzdGNsb3NlIChvciBzb21lIG90aGVyCnN1aXRhYmxlIHBsYWNlKT8gQnV0 IEkgc3VwcG9zZSB0aGF0IGNvdWxkIGJyZWFrIHNvbWV0aGluZyBlbHNlIHRoYXQKYXNzdW1lIHRo YXQgZHJtX21vZGVfY3Vyc29yX2lvY3RsKCkgd2lsbCBkbyB0aGUgcmVzZXQuCgo+IAo+IFRoYW5r cywKPiBUaG9tYXMKPiAKPiAKPiA+Cj4gPiBDaGVlcnMsIERhbmllbAo+ID4+IC0tLQo+ID4+ICBk cml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyB8IDEwICsrKysrKy0tLS0KPiA+PiAgMSBmaWxlIGNo YW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0 Yy5jCj4gPj4gaW5kZXggMjRjNTQzNC4uOTNmODBhNSAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vZHJtX2NydGMuYwo+ID4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fY3J0Yy5j Cj4gPj4gQEAgLTI4NzQsNyArMjg3NCw4IEBAIHN0YXRpYyBpbnQgZHJtX21vZGVfY3Vyc29yX3Vu aXZlcnNhbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsCj4gPj4gIAo+ID4+ICBzdGF0aWMgaW50IGRy bV9tb2RlX2N1cnNvcl9jb21tb24oc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+PiAgCQkJCSAg c3RydWN0IGRybV9tb2RlX2N1cnNvcjIgKnJlcSwKPiA+PiAtCQkJCSAgc3RydWN0IGRybV9maWxl ICpmaWxlX3ByaXYpCj4gPj4gKwkJCQkgIHN0cnVjdCBkcm1fZmlsZSAqZmlsZV9wcml2LAo+ID4+ ICsJCQkJICBib29sIGZyb21fMikKPiA+PiAgewo+ID4+ICAJc3RydWN0IGRybV9jcnRjICpjcnRj Owo+ID4+ICAJaW50IHJldCA9IDA7Cj4gPj4gQEAgLTI5MDcsNyArMjkwOCw4IEBAIHN0YXRpYyBp bnQgZHJtX21vZGVfY3Vyc29yX2NvbW1vbihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJ CQlnb3RvIG91dDsKPiA+PiAgCQl9Cj4gPj4gIAkJLyogVHVybnMgb2ZmIHRoZSBjdXJzb3IgaWYg aGFuZGxlIGlzIDAgKi8KPiA+PiAtCQlpZiAoY3J0Yy0+ZnVuY3MtPmN1cnNvcl9zZXQyKQo+ID4+ ICsJCWlmIChjcnRjLT5mdW5jcy0+Y3Vyc29yX3NldDIgJiYKPiA+PiArCQkgICAgKGZyb21fMiB8 fCAhY3J0Yy0+ZnVuY3MtPmN1cnNvcl9zZXQpKQo+ID4+ICAJCQlyZXQgPSBjcnRjLT5mdW5jcy0+ Y3Vyc29yX3NldDIoY3J0YywgZmlsZV9wcml2LCByZXEtPmhhbmRsZSwKPiA+PiAgCQkJCQkJICAg ICAgcmVxLT53aWR0aCwgcmVxLT5oZWlnaHQsIHJlcS0+aG90X3gsIHJlcS0+aG90X3kpOwo+ID4+ ICAJCWVsc2UKPiA+PiBAQCAtMjk1Myw3ICsyOTU1LDcgQEAgaW50IGRybV9tb2RlX2N1cnNvcl9p b2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJbWVtY3B5KCZuZXdfcmVxLCByZXEs IHNpemVvZihzdHJ1Y3QgZHJtX21vZGVfY3Vyc29yKSk7Cj4gPj4gIAluZXdfcmVxLmhvdF94ID0g bmV3X3JlcS5ob3RfeSA9IDA7Cj4gPj4gIAo+ID4+IC0JcmV0dXJuIGRybV9tb2RlX2N1cnNvcl9j b21tb24oZGV2LCAmbmV3X3JlcSwgZmlsZV9wcml2KTsKPiA+PiArCXJldHVybiBkcm1fbW9kZV9j dXJzb3JfY29tbW9uKGRldiwgJm5ld19yZXEsIGZpbGVfcHJpdiwgZmFsc2UpOwo+ID4+ICB9Cj4g Pj4gIAo+ID4+ICAvKioKPiA+PiBAQCAtMjk3Niw3ICsyOTc4LDcgQEAgaW50IGRybV9tb2RlX2N1 cnNvcjJfaW9jdGwoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiA+PiAgewo+ID4+ICAJc3RydWN0 IGRybV9tb2RlX2N1cnNvcjIgKnJlcSA9IGRhdGE7Cj4gPj4gIAo+ID4+IC0JcmV0dXJuIGRybV9t b2RlX2N1cnNvcl9jb21tb24oZGV2LCByZXEsIGZpbGVfcHJpdik7Cj4gPj4gKwlyZXR1cm4gZHJt X21vZGVfY3Vyc29yX2NvbW1vbihkZXYsIHJlcSwgZmlsZV9wcml2LCB0cnVlKTsKPiA+PiAgfQo+ ID4+ICAKPiA+PiAgLyoqCj4gPj4gLS0gCj4gPj4gMi40LjMKPiA+Pgo+ID4+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPj4gZHJpLWRldmVsIG1haWxp bmcgbGlzdAo+ID4+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiA+PiBodHRwczov L3VybGRlZmVuc2UucHJvb2Zwb2ludC5jb20vdjIvdXJsP3U9aHR0cC0zQV9fbGlzdHMuZnJlZWRl c2t0b3Aub3JnX21haWxtYW5fbGlzdGluZm9fZHJpLTJEZGV2ZWwmZD1CUUlCQWcmYz1TcWNsMEV6 Nk0wWDhhZU02N0xLSWlESkFYVmVBdy1ZaWhWTU50WHQtdUVzJnI9dnB1a1BrQnRwb05RcDJJVUt1 RnZpT21QTllXVkttZW4zSmVldTU1em1FQSZtPUx2YW9XS25lWkJNcW9xdm9ubU5idHJROXNZMWRM NXVuQ0dfRDJfWGItLVkmcz1JcGVuWWtPZU9GU01rQ0J2TXAxX1RFYW03LUtkRlg0emJmQ0M5NDNH QzNNJmU9IAo+IAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVsCgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=