From: Patrick McHardy <kaber@trash.net>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: GIT: [PATCH v3 0/3] netfilter trace infrastructure support
Date: Fri, 27 Nov 2015 18:55:16 +0000 [thread overview]
Message-ID: <20151127185516.GA18898@macbook.localdomain> (raw)
In-Reply-To: <1448649800-26153-1-git-send-email-fw@strlen.de>
On 27.11, Florian Westphal wrote:
> 3rd round.
>
> See the individual patches for changelog vs. V 2.
>
> Patrick: Nothing fancy from libnftnl side, just the 3 new attributes
> (oiftype, nfproto, policy).
>
> On kernel side I addressed all of the comments.
>
> In case of NFPROTO_INET, the new NFTA_TRACE_NFPROTO will be 'NFPROTO_IPV4'
> (or IPV6), the netlink header family is set to NFPROTO_INET.
That's sounds good.
> I tried to reduce nft_do_chain bloat, +80 on my system.
That's even better than I expected, thanks!
> We have one unconditional foo = false assignment, all nftrace calls
> are avoided in 'no trace rules set' case via static key.
>
> Let me know if you spot more problems.
I'll review it tommorrow if you don't mind, currently trying to wrap my
head around the sub-byte and offset expressions. We have some limitations
which I'd like to address if I'm already working in that area before I
continue on the tracing part.
prev parent reply other threads:[~2015-11-27 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 18:43 GIT: [PATCH v3 0/3] netfilter trace infrastructure support Florian Westphal
2015-11-27 18:43 ` [PATCH v3 libnftnl 1/3] src: add " Florian Westphal
2015-12-09 13:55 ` Pablo Neira Ayuso
2015-12-09 14:06 ` Florian Westphal
2015-11-27 18:43 ` [PATCH v2 nf-next 2/3] netfilter: nf_tables: extend tracing infrastructure Florian Westphal
2015-11-28 12:36 ` Patrick McHardy
2015-11-27 18:43 ` [PATCH v3 nf-next 3/3] netfilter: nf_tables: wrap tracing with a static key Florian Westphal
2015-11-27 18:55 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151127185516.GA18898@macbook.localdomain \
--to=kaber@trash.net \
--cc=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.