From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754566AbbK0T4d (ORCPT ); Fri, 27 Nov 2015 14:56:33 -0500 Received: from mail.kernel.org ([198.145.29.136]:52722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbbK0T4a (ORCPT ); Fri, 27 Nov 2015 14:56:30 -0500 Date: Fri, 27 Nov 2015 16:56:27 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 1/3] perf report: Show error message when processing sample fails Message-ID: <20151127195627.GI5934@kernel.org> References: <1448645559-31167-1-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448645559-31167-1-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Nov 28, 2015 at 02:32:37AM +0900, Namhyung Kim escreveu: > Currently when perf fails to process samples for some reason, it doesn't > show any message about the failure. This is very inconvenient for users > especially on TUI as screen is reset after the failure. > > Signed-off-by: Namhyung Kim > --- > tools/perf/builtin-report.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > index 8a9c6908f54e..af5db885ea9c 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -513,20 +513,26 @@ static int __cmd_report(struct report *rep) > if (rep->cpu_list) { > ret = perf_session__cpu_bitmap(session, rep->cpu_list, > rep->cpu_bitmap); > - if (ret) > + if (ret) { > + ui__error("failed to set cpu bitmap\n"); Why? See below. > return ret; > + } > } > > if (rep->show_threads) > perf_read_values_init(&rep->show_threads_values); > > ret = report__setup_sample_type(rep); > - if (ret) > + if (ret) { > + /* report__setup_sample_type() already showed error message */ > return ret; > + } > > ret = perf_session__process_events(session); > - if (ret) > + if (ret) { > + ui__error("failed to process sample\n"); > return ret; > + } I'm applying this because it removes the potential flash, but would be good to have the reason for this failure shown to the user. - Arnaldo