From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751866AbbK1Ax4 (ORCPT ); Fri, 27 Nov 2015 19:53:56 -0500 Received: from mail.kernel.org ([198.145.29.136]:34075 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751009AbbK1Axz (ORCPT ); Fri, 27 Nov 2015 19:53:55 -0500 Date: Fri, 27 Nov 2015 21:53:51 -0300 From: Arnaldo Carvalho de Melo To: Namhyung Kim Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH 3/3] perf hists browser: Update nr entries regardless of min percent Message-ID: <20151128005351.GL5934@kernel.org> References: <1448645559-31167-1-git-send-email-namhyung@kernel.org> <1448645559-31167-3-git-send-email-namhyung@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448645559-31167-3-git-send-email-namhyung@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Sat, Nov 28, 2015 at 02:32:39AM +0900, Namhyung Kim escreveu: > When perf report on TUI was called with -S symbol filter, it should > update nr entries even if min_pcnt is 0. IIRC the reason was to update > nr entries after applying minimum percent threshold. But if symbol > filter was given on command line (with -S option), it should use > hists->nr_non_filtered_entries instead of hists->nr_entries. > > So this patch fixes a bug of navigating hists browser that the cursor > goes beyond the number of entries when -S (or similar) option is used. Thanks, tested and applied. - Arnaldo