From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: [radeon r100] when ring test fails, provide users with option to test Date: Sat, 28 Nov 2015 21:58:40 +0100 Message-ID: <20151128205840.GA26757@amd> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTP id B2B786E2F6 for ; Sat, 28 Nov 2015 12:58:45 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Trivial patch monkey , alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org ClJpbmcgdGVzdCBmYWlsdXJlIGlzIG9mdGVuIGNhdXNlZCBieSB0b28gaGlnaCBhZ3Btb2RlLiBU ZWxsIHRoZSB1c2VyCndoYXQgdG8gdHJ5LgoKU2lnbmVkLW9mZi1ieTogUGF2ZWwgTWFjaGVrIDxw YXZlbEB1Y3cuY3o+CgpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yMTAwLmMg Yi9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3IxMDAuYwppbmRleCAyMzhiMTNmLi4zMmIxOTE3IDEw MDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vcmFkZW9uL3IxMDAuYworKysgYi9kcml2ZXJzL2dw dS9kcm0vcmFkZW9uL3IxMDAuYwpAQCAtMzY2NSw3ICszNjY1LDcgQEAgaW50IHIxMDBfcmluZ190 ZXN0KHN0cnVjdCByYWRlb25fZGV2aWNlICpyZGV2LCBzdHJ1Y3QgcmFkZW9uX3JpbmcgKnJpbmcp CiAJaWYgKGkgPCByZGV2LT51c2VjX3RpbWVvdXQpIHsKIAkJRFJNX0lORk8oInJpbmcgdGVzdCBz dWNjZWVkZWQgaW4gJWQgdXNlY3NcbiIsIGkpOwogCX0gZWxzZSB7Ci0JCURSTV9FUlJPUigicmFk ZW9uOiByaW5nIHRlc3QgZmFpbGVkIChzY3JhdGNoKDB4JTA0WCk9MHglMDhYKVxuIiwKKwkJRFJN X0VSUk9SKCJyYWRlb246IHJpbmcgdGVzdCBmYWlsZWQgKHNjcmF0Y2goMHglMDRYKT0weCUwOFgp LCB0cnkgcmFkZW9uLmFncG1vZGU9MT9cbiIsCiAJCQkgIHNjcmF0Y2gsIHRtcCk7CiAJCXIgPSAt RUlOVkFMOwogCX0KCi0tIAooZW5nbGlzaCkgaHR0cDovL3d3dy5saXZlam91cm5hbC5jb20vfnBh dmVsbWFjaGVrCihjZXNreSwgcGljdHVyZXMpIGh0dHA6Ly9hdHJleS5rYXJsaW4ubWZmLmN1bmku Y3ovfnBhdmVsL3BpY3R1cmUvaG9yc2VzL2Jsb2cuaHRtbApfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZl bEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752943AbbK1U6q (ORCPT ); Sat, 28 Nov 2015 15:58:46 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47403 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427AbbK1U6o (ORCPT ); Sat, 28 Nov 2015 15:58:44 -0500 Date: Sat, 28 Nov 2015 21:58:40 +0100 From: Pavel Machek To: Trivial patch monkey , alexander.deucher@amd.com, christian.koenig@amd.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [radeon r100] when ring test fails, provide users with option to test Message-ID: <20151128205840.GA26757@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ring test failure is often caused by too high agpmode. Tell the user what to try. Signed-off-by: Pavel Machek diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index 238b13f..32b1917 100644 --- a/drivers/gpu/drm/radeon/r100.c +++ b/drivers/gpu/drm/radeon/r100.c @@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring) if (i < rdev->usec_timeout) { DRM_INFO("ring test succeeded in %d usecs\n", i); } else { - DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n", + DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n", scratch, tmp); r = -EINVAL; } -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html