Re: [iproute PATCH 0/5] warning-annoyance induced code-review

[Stephen Hemminger <shemming@brocade.com>]

On Sat, 28 Nov 2015 01:00:00 +0100
Phil Sutter <phil@nwl.cc> wrote:

> The primary goal was to get rid of the -Wunused-result warnings emitted
> during compiling. While adding the necessary checks, I found a few
> functions which could benefit from a bigger review (patches 1, 2 and 3).
> Patch 4 then adds the remaining missing checks, and patch 5 simplifies
> fgets() usage at a few spots.
> 
> Note that the last patch is my first Coccinelle-generated change, which
> makes me especially proud. Many thanks again to Julia Lawall for her kind
> support via IRC at this point!
> 
> Phil Sutter (5):
>   lnstat: review lnstat_update()
>   ss: reduce max indentation level in init_service_resolver()
>   ss: review is_ephemeral()
>   get rid of remaining -Wunused-result warnings
>   get rid of unnecessary fgets() buffer size limitation
> 
>  misc/arpd.c        |   2 +-
>  misc/ifstat.c      |   6 ++-
>  misc/lnstat_util.c |  21 +++++------
>  misc/nstat.c       |   6 ++-
>  misc/ss.c          | 107 ++++++++++++++++++++++++++++-------------------------
>  5 files changed, 74 insertions(+), 68 deletions(-)
> 

Applied, thanks