From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] altera_qspi: fix erase and write error code
Date: Sun, 29 Nov 2015 14:35:41 +0100 [thread overview]
Message-ID: <201511291435.41378.marex@denx.de> (raw)
In-Reply-To: <1448797103-30524-2-git-send-email-thomas@wytron.com.tw>
On Sunday, November 29, 2015 at 12:38:23 PM, Thomas Chou wrote:
> Fix erase and write error code, which should be "protected".
Can you elaborate on why do you think this change is correct please ?
That reasoning should be part of the patch description.
> Signed-off-by: Thomas Chou <thomas@wytron.com.tw>
> ---
> drivers/mtd/altera_qspi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/altera_qspi.c b/drivers/mtd/altera_qspi.c
> index 89f04a4..cf45e73 100644
> --- a/drivers/mtd/altera_qspi.c
> +++ b/drivers/mtd/altera_qspi.c
> @@ -77,7 +77,7 @@ int flash_erase(flash_info_t *info, int s_first, int
> s_last) instr.len = mtd->erasesize * (s_last + 1 - s_first);
> ret = mtd_erase(mtd, &instr);
> if (ret)
> - return ERR_NOT_ERASED;
> + return ERR_PROTECTED;
>
> return 0;
> }
> @@ -94,7 +94,7 @@ int write_buff(flash_info_t *info, uchar *src, ulong
> addr, ulong cnt)
>
> ret = mtd_write(mtd, to, cnt, &retlen, src);
> if (ret)
> - return ERR_NOT_ERASED;
> + return ERR_PROTECTED;
>
> return 0;
> }
Best regards,
Marek Vasut
next prev parent reply other threads:[~2015-11-29 13:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-29 11:38 [U-Boot] [PATCH 1/2] altera_qspi: add lock unlock ops Thomas Chou
2015-11-29 11:38 ` [U-Boot] [PATCH 2/2] altera_qspi: fix erase and write error code Thomas Chou
2015-11-29 13:35 ` Marek Vasut [this message]
2015-12-01 7:21 ` Chin Liang See
2015-11-29 13:34 ` [U-Boot] [PATCH 1/2] altera_qspi: add lock unlock ops Marek Vasut
2015-12-01 7:09 ` Chin Liang See
2015-12-01 9:07 ` [U-Boot] [PATCH v2 " Thomas Chou
2015-12-01 9:07 ` [U-Boot] [PATCH v2 2/2] altera_qspi: fix erase and write error code Thomas Chou
2015-12-01 13:24 ` Marek Vasut
2015-12-06 3:33 ` Thomas Chou
2015-12-01 13:23 ` [U-Boot] [PATCH v2 1/2] altera_qspi: add lock unlock ops Marek Vasut
2015-12-06 3:32 ` Thomas Chou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201511291435.41378.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.