From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash
Date: Sun, 29 Nov 2015 15:35:48 +0100 [thread overview]
Message-ID: <20151129153548.304522af@free-electrons.com> (raw)
In-Reply-To: <1448709248-21177-5-git-send-email-sebastian.hesselbarth@gmail.com>
Sebastian,
Adding Ezequiel Garcia in Cc.
On Sat, 28 Nov 2015 12:14:08 +0100, Sebastian Hesselbarth wrote:
> The NAND device found on Lenovo ix4-300d uses 4-bit BCH ECC protection.
> Add the corresponding properties to the NAND node.
If the ONFI information from the NAND flash say that it requires 4 bits
per 512, then there should be no need to add this information to the
Device Tree as the pxa3xx_nand driver by default uses the ONFI
information.
Those properties are only needed when for some reason the vendor has
chosen to use a ECC strength that doesn't match with the one advertised
by the flash in its ONFI information (either stronger or weaker). But
in this case, your commit log is confusing, because it says that the
"NAND device ... uses 4-bit BCH ECC protection". If it really does,
then the patch is not needed :-)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Gregory Clement
<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Benoit Masson <yahoo-+V3Jd3LB6RBWk0Htik3J/w@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Ezequiel Garcia
<ezequiel.garcia-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Subject: Re: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash
Date: Sun, 29 Nov 2015 15:35:48 +0100 [thread overview]
Message-ID: <20151129153548.304522af@free-electrons.com> (raw)
In-Reply-To: <1448709248-21177-5-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Sebastian,
Adding Ezequiel Garcia in Cc.
On Sat, 28 Nov 2015 12:14:08 +0100, Sebastian Hesselbarth wrote:
> The NAND device found on Lenovo ix4-300d uses 4-bit BCH ECC protection.
> Add the corresponding properties to the NAND node.
If the ONFI information from the NAND flash say that it requires 4 bits
per 512, then there should be no need to add this information to the
Device Tree as the pxa3xx_nand driver by default uses the ONFI
information.
Those properties are only needed when for some reason the vendor has
chosen to use a ECC strength that doesn't match with the one advertised
by the flash in its ONFI information (either stronger or weaker). But
in this case, your commit log is confusing, because it says that the
"NAND device ... uses 4-bit BCH ECC protection". If it really does,
then the patch is not needed :-)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
Gregory Clement <gregory.clement@free-electrons.com>,
Benoit Masson <yahoo@perenite.com>,
linux-arm-kernel@lists.infradead.org,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash
Date: Sun, 29 Nov 2015 15:35:48 +0100 [thread overview]
Message-ID: <20151129153548.304522af@free-electrons.com> (raw)
In-Reply-To: <1448709248-21177-5-git-send-email-sebastian.hesselbarth@gmail.com>
Sebastian,
Adding Ezequiel Garcia in Cc.
On Sat, 28 Nov 2015 12:14:08 +0100, Sebastian Hesselbarth wrote:
> The NAND device found on Lenovo ix4-300d uses 4-bit BCH ECC protection.
> Add the corresponding properties to the NAND node.
If the ONFI information from the NAND flash say that it requires 4 bits
per 512, then there should be no need to add this information to the
Device Tree as the pxa3xx_nand driver by default uses the ONFI
information.
Those properties are only needed when for some reason the vendor has
chosen to use a ECC strength that doesn't match with the one advertised
by the flash in its ONFI information (either stronger or weaker). But
in this case, your commit log is confusing, because it says that the
"NAND device ... uses 4-bit BCH ECC protection". If it really does,
then the patch is not needed :-)
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-29 14:35 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-28 11:14 [PATCH 0/4] ARM: dt: mvebu: ix4-300d: NAND cleanup and ECC Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 11:14 ` [PATCH 1/4] ARM: dt: mvebu: ix4-300d: remove whole flash partition Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 16:52 ` Andrew Lunn
2015-11-28 16:52 ` Andrew Lunn
2015-11-28 16:52 ` Andrew Lunn
2015-11-28 17:38 ` Sebastian Hesselbarth
2015-11-28 17:38 ` Sebastian Hesselbarth
2015-11-28 17:38 ` Sebastian Hesselbarth
2015-11-28 20:32 ` Benoit Masson
2015-11-28 20:32 ` Benoit Masson
2015-11-28 20:32 ` Benoit Masson
2015-11-28 21:11 ` Andrew Lunn
2015-11-28 21:11 ` Andrew Lunn
2015-11-30 14:16 ` Gregory CLEMENT
2015-11-30 14:16 ` Gregory CLEMENT
2015-11-28 11:14 ` [PATCH 2/4] ARM: dt: mvebu: ix4-300d: move partitions to partition sub-node Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 17:00 ` Andrew Lunn
2015-11-28 17:00 ` Andrew Lunn
2015-11-28 17:00 ` Andrew Lunn
2015-11-28 17:38 ` Sebastian Hesselbarth
2015-11-28 17:38 ` Sebastian Hesselbarth
2015-11-30 14:17 ` Gregory CLEMENT
2015-11-30 14:17 ` Gregory CLEMENT
2015-11-28 11:14 ` [PATCH 3/4] ARM: dt: mvebu: ix4-300d: Cleanup NAND partition ranges Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 17:01 ` Andrew Lunn
2015-11-28 17:01 ` Andrew Lunn
2015-11-28 17:01 ` Andrew Lunn
2015-11-30 14:20 ` Gregory CLEMENT
2015-11-30 14:20 ` Gregory CLEMENT
2015-11-30 14:20 ` Gregory CLEMENT
2015-11-28 11:14 ` [PATCH 4/4] ARM: dt: mvebu: ix4-300d: Add ECC properties to NAND flash Sebastian Hesselbarth
2015-11-28 11:14 ` Sebastian Hesselbarth
2015-11-28 17:02 ` Andrew Lunn
2015-11-28 17:02 ` Andrew Lunn
2015-11-28 17:02 ` Andrew Lunn
2015-11-29 14:35 ` Thomas Petazzoni [this message]
2015-11-29 14:35 ` Thomas Petazzoni
2015-11-29 14:35 ` Thomas Petazzoni
2015-11-30 8:30 ` Sebastian Hesselbarth
2015-11-30 8:30 ` Sebastian Hesselbarth
2015-11-30 8:30 ` Sebastian Hesselbarth
2015-11-30 14:22 ` Gregory CLEMENT
2015-11-30 14:22 ` Gregory CLEMENT
2015-11-30 14:22 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151129153548.304522af@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.