From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5] pkg-download: do not test SITE_METHOD
Date: Sun, 29 Nov 2015 18:57:23 +0100 [thread overview]
Message-ID: <20151129175723.GD3630@free.fr> (raw)
In-Reply-To: <1447929366-8972-2-git-send-email-jezz@sysmic.org>
J?r?me, All,
On 2015-11-19 11:36 +0100, J?r?me Pouiller spake thusly:
> SITE_METHOD is always set in inner-generic-package. So, it is useless
> to test it in pkg-download.
>
> Signed-off-by: J?r?me Pouiller <jezz@sysmic.org>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> package/pkg-download.mk | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/package/pkg-download.mk b/package/pkg-download.mk
> index c86b9ab..757bafe 100644
> --- a/package/pkg-download.mk
> +++ b/package/pkg-download.mk
> @@ -222,12 +222,7 @@ define DOWNLOAD_INNER
> exit 1 ; \
> fi ; \
> if test -n "$(1)" ; then \
> - if test -z "$($(PKG)_SITE_METHOD)" ; then \
> - scheme="$(call geturischeme,$(1))" ; \
> - else \
> - scheme="$($(PKG)_SITE_METHOD)" ; \
> - fi ; \
> - case "$$scheme" in \
> + case "$($(PKG)_SITE_METHOD)" in \
> git) $($(3)_GIT) && exit ;; \
> svn) $($(3)_SVN) && exit ;; \
> cvs) $($(3)_CVS) && exit ;; \
> --
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2015-11-29 17:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-19 10:36 [Buildroot] [PATCH 0/5] Introduce alternative archive format Jérôme Pouiller
2015-11-19 10:36 ` [Buildroot] [PATCH 1/5] pkg-download: do not test SITE_METHOD Jérôme Pouiller
2015-11-29 17:57 ` Yann E. MORIN [this message]
2015-12-18 9:08 ` Thomas Petazzoni
2015-11-19 10:36 ` [Buildroot] [PATCH 2/5] download/git: allow to create archives containing shallowed git repos Jérôme Pouiller
2015-11-19 10:36 ` [Buildroot] [PATCH 3/5] pkg-generic: allow to populate build directory from a git archive Jérôme Pouiller
2015-11-19 10:36 ` [Buildroot] [PATCH 4/5] pkg-generic: provide an option to use git archives Jérôme Pouiller
2015-11-19 10:36 ` [Buildroot] [PATCH 5/5] pkg-generic: tag sources if git is used Jérôme Pouiller
2015-11-19 12:02 ` [Buildroot] [PATCH 0/5] Introduce alternative archive format Thomas Petazzoni
2015-11-23 9:54 ` Jérôme Pouiller
2015-11-29 18:02 ` Yann E. MORIN
2015-11-30 12:32 ` Jérôme Pouiller
2015-11-29 21:05 ` Arnout Vandecappelle
2015-12-29 21:36 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151129175723.GD3630@free.fr \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.