From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [radeon r100] when ring test fails, provide users with option to test Date: Sun, 29 Nov 2015 23:22:35 +0100 Message-ID: <20151129222235.GA25692@amd> References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from atrey.karlin.mff.cuni.cz (atrey.karlin.mff.cuni.cz [195.113.26.193]) by gabe.freedesktop.org (Postfix) with ESMTP id 4FB166E2FC for ; Sun, 29 Nov 2015 14:22:38 -0800 (PST) Content-Disposition: inline In-Reply-To: <565B56A5.4080702@amd.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: alexander.deucher@amd.com, Trivial patch monkey , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU3VuIDIwMTUtMTEtMjkgMjA6NDg6NTMsIENocmlzdGlhbiBLw7ZuaWcgd3JvdGU6Cj4gT24g MjguMTEuMjAxNSAyMTo1OCwgUGF2ZWwgTWFjaGVrIHdyb3RlOgo+ID5SaW5nIHRlc3QgZmFpbHVy ZSBpcyBvZnRlbiBjYXVzZWQgYnkgdG9vIGhpZ2ggYWdwbW9kZS4gVGVsbCB0aGUgdXNlcgo+ID53 aGF0IHRvIHRyeS4KPiA+Cj4gPlNpZ25lZC1vZmYtYnk6IFBhdmVsIE1hY2hlayA8cGF2ZWxAdWN3 LmN6Pgo+IAo+IE5BSywgdGhlIHJpbmcgdGVzdCBjYW4gZmFpbCBmb3IgYW55IG51bWJlciBvZiBy ZWFzb25zIGFuZCB0aGUgYWdwbW9kZSBpcwo+IGFjdHVhbGx5IHJhdGhlciB1bmxpa2VseSB0byBi ZSB0aGUgY2F1c2UuCgpXZWxsLCB3aGVuIEkgYXNrZWQgb24gdGhlIGxpc3QgIndoeSB0aGlzIGlz IGhhcHBlbmVkIiBJIGdvdCAidW1tLApub29uZSBrbm93cyIgcmVzcG9uc2UgdGhhdCB3YXMgbm90 IGV4YWN0bHkgaGVscGZ1bC4gQW5kIHRoZW4gc29tZW9uZQp0b2xkIG1lIGFib3V0IGFncG1vZGUu CgpJZiB5b3Uga25vdyBhYm91dCB0aGUgcmVhc29ucyBpdCBjYW4gZmFpbCwgY291bGQgeW91IGxp c3QgdGhlbSBuZWFyCnRoZSBEUk1fRVJST1IsIGF0IGxlYXN0IGFzIGEgY29tbWVudD8KClRoYW5r cywKCQkJCQkJCQkJUGF2ZWwKCj4gUmVnYXJkcywKPiBDaHJpc3RpYW4uCj4gCj4gPgo+ID5kaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JhZGVvbi9yMTAwLmMgYi9kcml2ZXJzL2dwdS9kcm0v cmFkZW9uL3IxMDAuYwo+ID5pbmRleCAyMzhiMTNmLi4zMmIxOTE3IDEwMDY0NAo+ID4tLS0gYS9k cml2ZXJzL2dwdS9kcm0vcmFkZW9uL3IxMDAuYwo+ID4rKysgYi9kcml2ZXJzL2dwdS9kcm0vcmFk ZW9uL3IxMDAuYwo+ID5AQCAtMzY2NSw3ICszNjY1LDcgQEAgaW50IHIxMDBfcmluZ190ZXN0KHN0 cnVjdCByYWRlb25fZGV2aWNlICpyZGV2LCBzdHJ1Y3QgcmFkZW9uX3JpbmcgKnJpbmcpCj4gPiAg CWlmIChpIDwgcmRldi0+dXNlY190aW1lb3V0KSB7Cj4gPiAgCQlEUk1fSU5GTygicmluZyB0ZXN0 IHN1Y2NlZWRlZCBpbiAlZCB1c2Vjc1xuIiwgaSk7Cj4gPiAgCX0gZWxzZSB7Cj4gPi0JCURSTV9F UlJPUigicmFkZW9uOiByaW5nIHRlc3QgZmFpbGVkIChzY3JhdGNoKDB4JTA0WCk9MHglMDhYKVxu IiwKPiA+KwkJRFJNX0VSUk9SKCJyYWRlb246IHJpbmcgdGVzdCBmYWlsZWQgKHNjcmF0Y2goMHgl MDRYKT0weCUwOFgpLCB0cnkgcmFkZW9uLmFncG1vZGU9MT9cbiIsCj4gPiAgCQkJICBzY3JhdGNo LCB0bXApOwo+ID4gIAkJciA9IC1FSU5WQUw7Cj4gPiAgCX0KPiA+CgotLSAKKGVuZ2xpc2gpIGh0 dHA6Ly93d3cubGl2ZWpvdXJuYWwuY29tL35wYXZlbG1hY2hlawooY2Vza3ksIHBpY3R1cmVzKSBo dHRwOi8vYXRyZXkua2FybGluLm1mZi5jdW5pLmN6L35wYXZlbC9waWN0dXJlL2hvcnNlcy9ibG9n Lmh0bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751352AbbK2WWk (ORCPT ); Sun, 29 Nov 2015 17:22:40 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:45903 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750714AbbK2WWi (ORCPT ); Sun, 29 Nov 2015 17:22:38 -0500 Date: Sun, 29 Nov 2015 23:22:35 +0100 From: Pavel Machek To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: Trivial patch monkey , alexander.deucher@amd.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [radeon r100] when ring test fails, provide users with option to test Message-ID: <20151129222235.GA25692@amd> References: <20151128205840.GA26757@amd> <565B56A5.4080702@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <565B56A5.4080702@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 2015-11-29 20:48:53, Christian König wrote: > On 28.11.2015 21:58, Pavel Machek wrote: > >Ring test failure is often caused by too high agpmode. Tell the user > >what to try. > > > >Signed-off-by: Pavel Machek > > NAK, the ring test can fail for any number of reasons and the agpmode is > actually rather unlikely to be the cause. Well, when I asked on the list "why this is happened" I got "umm, noone knows" response that was not exactly helpful. And then someone told me about agpmode. If you know about the reasons it can fail, could you list them near the DRM_ERROR, at least as a comment? Thanks, Pavel > Regards, > Christian. > > > > >diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c > >index 238b13f..32b1917 100644 > >--- a/drivers/gpu/drm/radeon/r100.c > >+++ b/drivers/gpu/drm/radeon/r100.c > >@@ -3665,7 +3665,7 @@ int r100_ring_test(struct radeon_device *rdev, struct radeon_ring *ring) > > if (i < rdev->usec_timeout) { > > DRM_INFO("ring test succeeded in %d usecs\n", i); > > } else { > >- DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X)\n", > >+ DRM_ERROR("radeon: ring test failed (scratch(0x%04X)=0x%08X), try radeon.agpmode=1?\n", > > scratch, tmp); > > r = -EINVAL; > > } > > -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html