From: Stephen Hemminger <shemming@brocade.com>
To: Phil Sutter <phil@nwl.cc>
Cc: <netdev@vger.kernel.org>
Subject: Re: [iproute PATCH RFC] libnetlink: introduce DECLARE_NLREQ
Date: Mon, 30 Nov 2015 09:20:51 -0800 [thread overview]
Message-ID: <20151130092051.0feb5fe0@xeon-e3> (raw)
In-Reply-To: <20151130154724.GC17712@orbit.nwl.cc>
On Mon, 30 Nov 2015 16:47:25 +0100
Phil Sutter <phil@nwl.cc> wrote:
> libmnl looks nice and simple (unlike libnl I was initially looking at by
> accident). Now how to pull this off:
>
> I don't think mandatorily depending on libmnl will be acceptable, do
> you? So I can imagine two ways to do this:
Having libmnl be mandatory is fine, but please put in net-next.
Every distro has libmnl and as long as it is documented not a big deal.
> A) Have a libmnl version of lib/libnetlink.c which is used instead of
> the old one if libmnl is present.
>
> B) Pull a copy of libmnl into iproute2 sources so it's always available
> (as fallback) and make it replace lib/libnetlink.c. This sounds worse
> than it is, using git-subtree allows to do this without imposing user
> knowledge about it (like git-submodule does).
Just incrementally change code to use libmnl instead of libnetlink.
Start with simple stuff.
prev parent reply other threads:[~2015-11-30 17:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 13:26 [iproute PATCH RFC] libnetlink: introduce DECLARE_NLREQ Phil Sutter
2015-11-26 13:56 ` Hannes Frederic Sowa
2015-11-26 14:00 ` Phil Sutter
2015-11-29 20:07 ` Stephen Hemminger
2015-11-29 21:40 ` Phil Sutter
2015-11-30 15:47 ` Phil Sutter
2015-11-30 17:20 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130092051.0feb5fe0@xeon-e3 \
--to=shemming@brocade.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.