From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754842AbbK3PQG (ORCPT ); Mon, 30 Nov 2015 10:16:06 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:47608 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754341AbbK3PQC (ORCPT ); Mon, 30 Nov 2015 10:16:02 -0500 Date: Mon, 30 Nov 2015 07:16:01 -0800 From: Greg KH To: Rajan Vaja Cc: carlos@cgarcia.org, mahfouz.saif.elyazal@gmail.com, rodriguez.twister@gmail.com, peter@hurleysoftware.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fwserial: Fix coding style problems Message-ID: <20151130151601.GA28140@kroah.com> References: <1448867683-1985-1-git-send-email-rajan.vaja@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448867683-1985-1-git-send-email-rajan.vaja@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 30, 2015 at 12:44:43PM +0530, Rajan Vaja wrote: > Fix below coding style problems reported by checkpatch: > - Check for pointer comparisons to NULL > - No space after a cast That's two different things, please break this into two different patches. thanks, greg k-h