All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Artemiy Volkov <artemiyv@acm.org>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH v3] e2fsck: do not read EA header beyond the end of an inode
Date: Mon, 30 Nov 2015 12:06:52 -0500	[thread overview]
Message-ID: <20151130170652.GC4316@thunk.org> (raw)
In-Reply-To: <1448571594-32225-1-git-send-email-artemiyv@acm.org>

On Thu, Nov 26, 2015 at 08:59:54PM +0000, Artemiy Volkov wrote:
> In check_inode_extra_space(), if we attempt to read an EA header at
> the end of the extra space, in a corrupted filesystem it may result in
> a read beyond the bounds of the inode. Add a check to prevent this.
> 
> Reproduced by running ./test_one --valgrind f_write_ea_toobig_extra_isize.
> 
> Signed-off-by: Artemiy Volkov <artemiyv@acm.org>

Applied, thanks.

					- Ted

      parent reply	other threads:[~2015-11-30 17:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 19:24 [PATCH] e2fsck: do not read EA header beyond the end of an inode Artemiy Volkov
2015-11-26 20:23 ` [PATCH v2] " Artemiy Volkov
2015-11-26 20:59   ` [PATCH v3] " Artemiy Volkov
2015-11-28 21:54     ` Darrick J. Wong
2015-11-30 17:06     ` Theodore Ts'o [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130170652.GC4316@thunk.org \
    --to=tytso@mit.edu \
    --cc=artemiyv@acm.org \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.