From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org, Jim Garlick <garlick@llnl.gov>,
Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH v2] tune2fs: warn if the filesystem journal is dirty
Date: Mon, 30 Nov 2015 12:14:45 -0500 [thread overview]
Message-ID: <20151130171445.GE4316@thunk.org> (raw)
In-Reply-To: <1448410059-3691-1-git-send-email-adilger@dilger.ca>
On Tue, Nov 24, 2015 at 05:07:39PM -0700, Andreas Dilger wrote:
> From: Jim Garlick <garlick@llnl.gov>
>
> Running tune2fs on a filesystem with an unrecovered journal can
> cause the tune2fs settings changes in the superblock to be reverted
> when the journal is replayed if it contains an uncommitted copy of
> the superblock. Print a warning if this is detected so that the
> user isn't surprised if it happens.
>
> Signed-off-by: Jim Garlick <garlick@llnl.gov>
>
> Updated message printed to include steps to replay journal.
>
> Signed-off-by: Andreas Dilger <andreas.dilger@intel.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2015-11-30 17:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 0:07 [PATCH v2] tune2fs: warn if the filesystem journal is dirty Andreas Dilger
2015-11-30 17:14 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130171445.GE4316@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=andreas.dilger@intel.com \
--cc=garlick@llnl.gov \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.