From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.free-electrons.com (down.free-electrons.com. [37.187.137.238]) by gmr-mx.google.com with ESMTP id e201si700324wma.3.2015.11.30.11.04.31 for ; Mon, 30 Nov 2015 11:04:31 -0800 (PST) Date: Mon, 30 Nov 2015 20:04:31 +0100 From: Alexandre Belloni To: LABBE Corentin Cc: a.zummo@towertech.it, linux-arm-kernel@lists.infradead.org, maxime.ripard@free-electrons.com, wens@csie.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: [rtc-linux] Re: [PATCH 1/3] rtc: sunxi: fix signedness issues Message-ID: <20151130190431.GK22136@piout.net> References: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 In-Reply-To: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On 19/11/2015 at 11:50:08 +0100, LABBE Corentin wrote : > The variable year must be set as unsigned since it is used with > sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which > wait for unsigned int. > Only tm_year is not unsigned, but it is long. > This patch fix also the format of printing of min/max. (must use %u since > they are unsigned) > > The parameter to of sunxi_rtc_setaie() must be set to uint since callers > give always uint data. > > Signed-off-by: LABBE Corentin > --- > drivers/rtc/rtc-sunxi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: alexandre.belloni@free-electrons.com (Alexandre Belloni) Date: Mon, 30 Nov 2015 20:04:31 +0100 Subject: [PATCH 1/3] rtc: sunxi: fix signedness issues In-Reply-To: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> References: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> Message-ID: <20151130190431.GK22136@piout.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 19/11/2015 at 11:50:08 +0100, LABBE Corentin wrote : > The variable year must be set as unsigned since it is used with > sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which > wait for unsigned int. > Only tm_year is not unsigned, but it is long. > This patch fix also the format of printing of min/max. (must use %u since > they are unsigned) > > The parameter to of sunxi_rtc_setaie() must be set to uint since callers > give always uint data. > > Signed-off-by: LABBE Corentin > --- > drivers/rtc/rtc-sunxi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754694AbbK3TEe (ORCPT ); Mon, 30 Nov 2015 14:04:34 -0500 Received: from down.free-electrons.com ([37.187.137.238]:45489 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753471AbbK3TEc (ORCPT ); Mon, 30 Nov 2015 14:04:32 -0500 Date: Mon, 30 Nov 2015 20:04:31 +0100 From: Alexandre Belloni To: LABBE Corentin Cc: a.zummo@towertech.it, linux-arm-kernel@lists.infradead.org, maxime.ripard@free-electrons.com, wens@csie.org, linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH 1/3] rtc: sunxi: fix signedness issues Message-ID: <20151130190431.GK22136@piout.net> References: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1447930210-27008-1-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19/11/2015 at 11:50:08 +0100, LABBE Corentin wrote : > The variable year must be set as unsigned since it is used with > sunxi_rtc_data_year{.min|.max} and as parameter of is_leap_year() which > wait for unsigned int. > Only tm_year is not unsigned, but it is long. > This patch fix also the format of printing of min/max. (must use %u since > they are unsigned) > > The parameter to of sunxi_rtc_setaie() must be set to uint since callers > give always uint data. > > Signed-off-by: LABBE Corentin > --- > drivers/rtc/rtc-sunxi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com