From: Brian Norris <computersforpeace@gmail.com>
To: Nikolay Martynov <mar.kolya@gmail.com>
Cc: linux-mtd@lists.infradead.org,
David Woodhouse <dwmw2@infradead.org>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH] mtd: nand: Fix Spansion sparearea size detection
Date: Mon, 30 Nov 2015 16:09:23 -0800 [thread overview]
Message-ID: <20151201000923.GQ64635@google.com> (raw)
In-Reply-To: <CALGY4fv1rbzng+aUbevJQRwj5X0R3NmzZ0iXz5ZNXxya0Rx6zw@mail.gmail.com>
Hi Nikolay,
On Mon, Nov 30, 2015 at 06:59:32PM -0500, Nikolay Martynov wrote:
> I'm sorry, I only have board with S34ML02G2 and I've tested by
> change on it - it works fine. But unfortunately I do not have any way
> to test S34ML01G2.
> It looks like that logic can be simplified if just check id_data[1]
> is one of 0xda, 0xdc, 0xca, 0xcc - this should be safer option.
Possibly safer, but it's uglier, and I'd like not to have to make this
change at all, if ONFI can help it.
> I'm sorry, I'm very new to all this. This patch made kernel boot on
> a board that I have. The kernel was 'oldish' - 3.18. So I'm not sure
> why ONFI is not used here, I will see if I can figure it out.
What NAND driver are you using? It's possible that it doesn't support
the PARAMETER READ command properly. If so, it'd be better to fix that
than to clutter the NAND core.
Regards,
Brian
next prev parent reply other threads:[~2015-12-01 0:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 6:25 [PATCH] mtd: nand: Fix Spansion sparearea size detection Nikolay Martynov
2015-11-30 20:35 ` Brian Norris
2015-11-30 23:59 ` Nikolay Martynov
2015-12-01 0:09 ` Brian Norris [this message]
2015-12-01 0:19 ` Nikolay Martynov
2015-12-01 1:05 ` Brian Norris
2015-12-01 1:20 ` Nikolay Martynov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201000923.GQ64635@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mar.kolya@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.