All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org,
	Alexander Sverdlin <alexander.sverdlin@nokia.com>,
	Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Subject: Re: [PATCH v2 1/1] i2c: core: fix a code to suppress a warning
Date: Tue, 1 Dec 2015 01:28:28 +0100	[thread overview]
Message-ID: <20151201002828.GA1517@katana> (raw)
In-Reply-To: <1445514483.22669.47.camel@linux.intel.com>

[-- Attachment #1: Type: text/plain, Size: 664 bytes --]

On Thu, Oct 22, 2015 at 02:48:03PM +0300, Andy Shevchenko wrote:
> On Fri, 2015-09-18 at 14:06 +0300, Andy Shevchenko wrote:
> > There is a warning when compiling i2c-core.c
> > drivers/i2c/i2c-core.c:2561:36: warning: dubious: x | !y
> > 
> > Fix it by using a plain bitwise AND since I2C_M_RD is a bit 0 and
> > thus we are
> > on the safe side.
> 
> Wolfram, as of today I didn't see this in linux-next. Should I amend
> this one somehow?

I am working on my own series, introducing a macro for this operation
which can be used in drivers, too. Just need to fiddle a little more
with my coccinelle scripts. Stay tuned!

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

      reply	other threads:[~2015-12-01  0:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 11:06 [PATCH v2 1/1] i2c: core: fix a code to suppress a warning Andy Shevchenko
     [not found] ` <1442574399-26131-1-git-send-email-andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-09-18 11:10   ` Alexander Sverdlin
2015-10-22 11:48 ` Andy Shevchenko
2015-12-01  0:28   ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201002828.GA1517@katana \
    --to=wsa@the-dreams.de \
    --cc=alexander.sverdlin@nokia.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=vladimir_zapolskiy@mentor.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.