From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Minchan Kim <minchan@kernel.org>
Cc: "kyeongdon.kim" <kyeongdon.kim@lge.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()
Date: Tue, 1 Dec 2015 09:33:47 +0900 [thread overview]
Message-ID: <20151201003347.GA653@swordfish> (raw)
In-Reply-To: <20151130231841.GA960@bbox>
On (12/01/15 08:18), Minchan Kim wrote:
[..]
> > As you know, if there is 'null' return, this function is called again to
> > get a memory in while() loop. I just checked this one with printk().
> >
> > If you guys don't mind, I'll test more with trace log to check time delay.
>
> No problem.
>
> >
> > However, If this is fully expectable status to you.
> > I think I don't need to do it.
>
> It's not what I expected. Actually, I thought failure of vmalloc
> in that place should be *really really* rare. I think it's caused by
> __GFP_NOMEMALLOC so I want to see test result without the flag.
hm, agree. otherwise the whole vmalloc() fallback thing adds a
little value. additional streams are really not that important
to waste emergency memory. a stream, once allocated, stays
forever (until user decrease the ->max_strm).
> Thanks for the careful test!
yes, thank you Kyeongdon.
-ss
next prev parent reply other threads:[~2015-12-01 0:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 4:10 [PATCH v3 0/2] zram/zcomp: stream allocation fixes and tweaks Sergey Senozhatsky
2015-11-27 4:10 ` [PATCH v3 1/2] zram/zcomp: use GFP_NOIO to allocate streams Sergey Senozhatsky
2015-11-30 7:09 ` Minchan Kim
2015-11-27 4:10 ` [PATCH v3 2/2] zram: try vmalloc() after kmalloc() Sergey Senozhatsky
2015-11-30 7:10 ` Minchan Kim
2015-11-30 10:42 ` kyeongdon.kim
2015-11-30 11:14 ` Sergey Senozhatsky
2015-12-01 2:04 ` kyeongdon.kim
[not found] ` <20151130231841.GA960@bbox>
2015-12-01 0:33 ` Sergey Senozhatsky [this message]
2015-12-01 2:31 ` kyeongdon.kim
2015-12-01 4:44 ` Minchan Kim
[not found] ` <20151201045535.GA5999@bbox>
2015-12-01 5:16 ` Sergey Senozhatsky
2015-12-01 6:35 ` Kyeongdon Kim
2015-12-01 7:15 ` Sergey Senozhatsky
2015-12-01 7:33 ` Sergey Senozhatsky
2015-12-01 8:16 ` Minchan Kim
2015-12-01 9:11 ` Sergey Senozhatsky
2015-12-01 7:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151201003347.GA653@swordfish \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kyeongdon.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.