Re: [PATCHv2] [layerindex-web] recipe blacklisted information

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2116 bytes --]

On Tue, Dec 01, 2015 at 11:22:01AM +1300, Paul Eggleton wrote:
> Hi Alex,
> 
> On Mon, 30 Nov 2015 16:03:05 Alex Franco wrote:
> > Display blacklisted information for recipes on Layerindex, in the
> > recipe details, as well as the recipe search page, and layer page
> > tables. This information is pulled from the PNBLACKLIST variable.
> > Includes a hover text containing the reason for blacklist labels.
> > 
> > Changes to Django and Layerindex files:
> > - models.py, update.py
> > - migration file
> > - templates and static content (stylesheet)
> > 
> > [YOCTO #7855]
> > 
> > Signed-off-by: Alex Franco <alejandro.franco@linux.intel.com>
> > ---
> >  .../0010_auto__add_field_recipe_blacklisted.py     | 197
> > +++++++++++++++++++++ layerindex/models.py                               | 
> >  1 +
> >  layerindex/static/css/additional.css               |  19 +-
> >  layerindex/update.py                               |   1 +
> >  templates/layerindex/detail.html                   |   3 +-
> >  templates/layerindex/recipedetail.html             |  13 +-
> >  templates/layerindex/recipes.html                  |   3 +-
> >  7 files changed, 232 insertions(+), 5 deletions(-)
> >  create mode 100644
> > layerindex/migrations/0010_auto__add_field_recipe_blacklisted.py
> > 
> This looks great, thanks.
> 
> Another thing that just occurred to me though - apologies for not raising it 
> earlier - for the benefit of newer users it may be useful to explain 
> implications of the blacklisting. What I'd suggest is we put a line after the 
> reason on the recipe detail page saying "This means that the recipe will not 
> be buildable until the PNBLACKLIST value is cleared and the issue that caused 
> it to be added has been fixed or worked around." (Just on the recipe detail 
> page - not in the popup.)
> 
> Does that sound OK?

Maybe some more information how to clear PNBLACKLIST (people often don't
know that they can just set it to empty value in their bbappend or even
distro/local config).

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]